-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[specs] Properly handle invalid pending requests originating from a DAPP #152
Comments
@WalletConnect/sdk-team Who was going to own this proposal? From memory I think it was @jakobuid? |
I don't remember tbh. But the what they say is good improvement on how we handle requests on wallet side. |
Let's come back to this topic after protocol refactor. |
To be investigated with Swift and Kotlin... if session requests are rejected after 5mins |
To sum up after SDK meeting: this will be a protocol change so should the timestamp be optional first and we could make i required after leaving |
Had this feedback from Unstoppable:
To deliver the first version of WC2 in Unstoppable only needs for WC2 SDK to properly handle invalid pending requests originating from a DAPP.
In other words the SDK on a client side should:
update itself when a request on the DAPP side is cancelled or times out.
the SDK should also notify the client so that invalid requests are removed from the client UI.
Both of the above are required to have a smooth and fast UI on a client side.
btw, same applies to Kotlin. Android integration is planned for the next week.
So, with that in mind, are you able to address the item above in the near future? Should be a quick fix on your end. We can assist as well if you need anything from our end
Status
Updated in:
The text was updated successfully, but these errors were encountered: