Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add save button functionality to domains settings #403

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

enesozturk
Copy link
Contributor

Description

Refactor the domain settings UX to give better feedback while the users update their configurations

Type of change

  • New feature (non-breaking change which adds functionality)

Fixes/Resolves (Optional)

Please list any issues that are fixed by this PR in the format #<issue number>. If it fixes multiple issues, please put each issue in a separate line. If this Pull Request does not fix any issues, please delete this section.

Examples/Screenshots (Optional)

Screenshot 2024-01-15 at 17 00 14

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Closes #330

@enesozturk enesozturk requested a review from devceline January 15, 2024 14:00
Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app-web3inbox ✅ Ready (Inspect) Visit Preview Jan 15, 2024 2:01pm

Copy link
Contributor

@chadyj chadyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the preview link 👍

Copy link
Collaborator

@devceline devceline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enesozturk enesozturk merged commit 047faf4 into main Jan 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings: Display app issues
3 participants