Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove console capture #410

Merged
merged 1 commit into from
Jan 16, 2024
Merged

chore: remove console capture #410

merged 1 commit into from
Jan 16, 2024

Conversation

devceline
Copy link
Collaborator

@devceline devceline commented Jan 16, 2024 •
edited
Loading

Description

  • Remove console capture in favor of logError

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vercel Vercel
Copy link

vercel bot commented Jan 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-web3inbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 6:19pm

@devceline devceline requested a review from enesozturk January 16, 2024 18:17
@devceline devceline merged commit 468154b into main Jan 16, 2024
3 checks passed
@devceline devceline deleted the fix/remove-console-captures branch January 16, 2024 18:20
enesozturk pushed a commit that referenced this pull request Jan 18, 2024
@devceline @enesozturk
chore: remove console capture (#410)
83a7bbc
enesozturk pushed a commit that referenced this pull request Jan 18, 2024
@devceline @enesozturk
chore: remove console capture (#410)
dc8eaa9
arein added a commit that referenced this pull request Jan 18, 2024
@enesozturk @arein
@devceline @bkrem
refactor: tests (#413)
ff47a7e 
* feat(ui-tests): scaffolds basic test

* feat: tests

* refactor: update breakpoints, handle breakpoint for explorer columns

* Fix/force watch subscriptions (#393)

* chore: add unregister functionality

* chore: add unregister to facade

* chore: add unregister others

* chore: run prettier

* chore(config): ensure Sentry captures `console.error` calls (#400)

* chore: remove console capture (#410)

* feat(ui-tests): scaffolds basic test

* feat: tests

* refactor: handle notification modal on ci, refactor tests

* refactor: remove privacy settings comp

* chore: update selectors

* chore: revert apps max width

---------

Co-authored-by: Derek <[email protected]>
Co-authored-by: Celine Sarafa <[email protected]>
Co-authored-by: Ben Kremer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enesozturk enesozturk enesozturk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devceline @enesozturk