Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the args' name problem #6

Open
TeeyoHuang opened this issue Jun 27, 2018 · 0 comments
Open

the args' name problem #6

TeeyoHuang opened this issue Jun 27, 2018 · 0 comments

Comments

@TeeyoHuang
Copy link

In the args list, you set the grid_size with default value of 4. Then you named two args - args.height, args.width- and set their values according to the grid_size.
However, I think the names of these args are misleading!

Actually, the size of the grid in your program is equal to the size of the input image, right?
And in the file -mnist_model.py, there is a sentence:
grid = source_coordinate.view(batch_size, self.args.image_height, self.args.image_width, 2)
So you also know that your args.grid_height and args.grid_width are not the real height and width of the grid in the STN.

the args.grid_size actually refers to the gird of control ponits but not the grid in the STN steps.

So I just think the name of the arg maybe misleading,
Of course, the program works very well ! Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant