Local: implement Put in an atomic, isolated, and durable way #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The filepath.Walk patch works around this Go issue: |
The local interface mimics object store, so PUT operations should not be visible to other readers until they are complete.
On Unix systems, Go's os.Walk involves a readdir() followed by an lstat() of each file found. Between those, the file may be deleted - this should not fail the entire operation of listing container's content.
urisimchoni
force-pushed
the
local-atomic
branch
from
27e22c7 to
5576ab7
Compare
|
rebased on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #219
One commit works around what I believe is an issue with the Go standard library, namely that os.Walk would report an error if readdir found a file and lstat fails with EEXIST - this may very well happen if the file got deleted between the readdir and the lstat.