From 8cc8a252953e92a1d38ce49618051bd1ce38cc68 Mon Sep 17 00:00:00 2001
From: Watheq Alshowaiter <watheq.alshowaiter@gmail.com>
Date: Sun, 21 Jul 2024 04:57:11 +0300
Subject: [PATCH] chore: remove unneeded workflow

---
 .github/workflows/sqlserver.yml | 66 ---------------------------------
 README.md                       |  2 +-
 src/RequiredFields.php          |  2 -
 3 files changed, 1 insertion(+), 69 deletions(-)
 delete mode 100644 .github/workflows/sqlserver.yml

diff --git a/.github/workflows/sqlserver.yml b/.github/workflows/sqlserver.yml
deleted file mode 100644
index 13569f7..0000000
--- a/.github/workflows/sqlserver.yml
+++ /dev/null
@@ -1,66 +0,0 @@
-name: sqlserver
-on:
-  push:
-    paths:
-      - "**.php"
-      - ".github/workflows/tests-for-laravel-versions.yml"
-      - ".github/workflows/tests-for-databases.yml"
-      - "phpunit.xml.dist"
-      - "composer.json"
-      - "composer.lock"
-  workflow_dispatch:
-
-jobs:
-  mssql:
-    runs-on: ubuntu-20.04
-
-    services:
-      sqlsrv:
-        image: mcr.microsoft.com/mssql/server:2019-latest
-        env:
-          ACCEPT_EULA: Y
-          SA_PASSWORD: Forge123
-        ports:
-          - 1433:1433
-
-    strategy:
-      fail-fast: true
-
-    name: SQL Server 2019
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-
-      - name: Setup PHP
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: 8.2
-          extensions: dom, curl, libxml, mbstring, zip, pcntl, sqlsrv, pdo, pdo_sqlsrv, odbc, pdo_odbc, :php-psr
-          tools: composer:v2
-          coverage: none
-
-      - name: Set Framework version
-        run: composer config version "11.x-dev"
-
-      - name: Install dependencies
-        run: composer update --prefer-stable --prefer-dist --no-interaction --no-progress
-
-      - name: Wait for SQL Server to be ready
-        run: |
-          echo "Waiting for SQL Server to start..."
-          for i in {1..30}; do
-            /opt/mssql-tools/bin/sqlcmd -S localhost -U SA -P Forge123 -Q "SELECT 1" && break
-            echo "SQL Server is starting up..."
-            sleep 2
-          done
-
-      - name: Execute tests
-        run: vendor/bin/phpunit
-        env:
-          DB_CONNECTION: sqlsrv
-          DB_HOST: localhost
-          DB_PORT: 1433
-          DB_DATABASE: master
-          DB_USERNAME: SA
-          DB_PASSWORD: Forge123
diff --git a/README.md b/README.md
index 5d91ecd..41beabf 100644
--- a/README.md
+++ b/README.md
@@ -225,7 +225,7 @@ So Briefly, This package is useful if:
 
 ✅ Supports PHP versions: 8.2, 8.1, 8.0, and 7.4.
 
-✅ Supports SQL databases: SQLite, MySQL/MariaDB, PostgreSQL, and SQL Server (not tested yet).
+✅ Supports SQL databases: SQLite, MySQL/MariaDB, PostgreSQL, and SQL Server.
 
 ✅ Fully automated testing with PHPUnit.
 
diff --git a/src/RequiredFields.php b/src/RequiredFields.php
index 2de1885..34023d4 100644
--- a/src/RequiredFields.php
+++ b/src/RequiredFields.php
@@ -261,8 +261,6 @@ private static function getRequiredFieldsForPostgres(
     }
 
     /**
-     * Not tested yet in machine with SQL SERVER todo remove this after fixing and in readme file (not tested)
-     *
      * @return array
      */
     private static function getRequiredFieldsForSqlServer(