-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.20.1 no logspam #2044
Closed
Closed
1.20.1 no logspam #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e2c64ef.
The proper way to make recipes depend on another mod being installed.
Update Guidebook's Creative Tab (fixes it missing in JEI)
These have either already been replaced, or are known to not be coming back.
Bump Curios to the latest available 1.20.1 version. Transient modifiers seem to handle relogs better, but is still very buggy.
Lower Contrast to match the current Curios default slot style.
Removed Some Log Spam
…tion Update Curios Implementation (1.20 API)
Made the Routing Node Amount Textbox selectable again. Fixes WayofTime#1980 Made the Text Box only selectable if a Ghost Filter Slot has been clicked. Prevents players from typing in a value for nothing. Added a Right-Click function to the text box. This will clear it, set the ghost item value back to 0 ("Everything"), and select the Text Box for a new number.
Fix and Upgrade Routing Node Amount Text Box
Vanilla now handles them using the Damage Type data system.
Expand InventoryHelper with methods to find a specific inventory, and all registered inventories excluding certain ones. Together these allow a method to check inventories in a specific order, but still be able to check all registered inventories. Update PlayerUtil.findItem() to use the update InventoryHelper. This is needed to allow it to check Curios and any add-on mod inventories. Decided to check Curios before the Main Inventory, but after the Off-Hand slot.
Gives the player a Bracelet slot by default. Allows the player to put the Training Bracelet in either the Bracelet or LA Socket slots. Add a note to the Sanguine Scientiem about how only one will work at a time; Off-hand > Curios > Main Inventory (including Main Hand) > Add-on inventories.
Adjusted `Utils.canPlayerSeeDemonWill()` and `Utils.getDemonWillResolution()` to use the `InventoryHelper`. Functionality Change: The new implementation checks only "active" slots (Main and Off-hands, Curios, and any slots add-ons mark as active). With base Blood Magic that means the gauge will only show up when held or in a Curios slot. Added tags needed to put the Demon Will Aura Gauge in the Curios Charm and LA Socket slots.
Add the Tags needed to put the Sigil of Suppression in the Charm and LA Socket slots.
The "Spectral Block" Block still exists. This just removes the Item version that crashes the game if someone *somehow* obtains it and tries to place it.
Added the BloodMagic:Sacrifice Damage Type to the "No Impact" Damage Type Tag. This stops the game from resetting the player's momentum when this damage occurs.
Gilded Living Armour Upgrade (1.20.1)
Added Death Messages
…k's-Item Deregister the Spectral Block's Item
More Curios, Related InventoryHelper Updates, & Demon Will Aura Gauge Tweak
…acrifice-Damage Add Sacrifice to "No Impact" Damage Type Tag
'monster soul' had been replaced by 'minecraft:gold ingot' when it should be 'forge:ingots/gold' like the ones to either side.
Fixed an issue where the music disc did not credit the author, Firel.
oops accidentally included all 1.18... |
reopen this and just retarget the PR on top |
nvm I see you created a new PR. no worries :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2038 by adding a guard for if the optional is empty...