🔧 FIREBASE ADMIN FIXES: Fixed subscription sync-status and other API routes

PROBLEM: Preview environment subscription sync failing with 'Cannot read properties of undefined (reading 'doc')'
ROOT CAUSE: Multiple API routes incorrectly destructuring from getFirebaseAdmin()

SOLUTION: Fixed Firebase Admin initialization pattern across all affected routes

KEY CHANGES:

�� Fixed getFirebaseAdmin() Usage Pattern:
❌ WRONG: const { adminDb } = getFirebaseAdmin();
✅ CORRECT: const admin = getFirebaseAdmin(); const adminDb = admin.firestore();

📍 Fixed Routes:
✅ app/api/subscription/sync-status/route.ts - Main issue causing preview errors
✅ app/api/admin/analytics-data/route.ts - Same destructuring bug
✅ app/api/auth/login/route.ts - Fixed auth and firestore destructuring
✅ app/api/dev/setup-test-allocations/route.ts - Fixed db destructuring

🛡️ Added Null Checks:
✅ Added proper null checking for Firebase Admin availability
✅ Return 500 error when Firebase Admin not available
✅ Consistent error handling across all routes

TECHNICAL DETAILS:

🔍 Root Cause Analysis:
- getFirebaseAdmin() returns admin instance directly (typeof admin)
- Routes were trying to destructure { adminDb, auth, firestore, db }
- This resulted in undefined values causing 'Cannot read properties' errors
- Preview environment was particularly affected due to initialization timing

🎯 Correct Pattern:

🔧 Environment Impact:
- Preview environment now properly handles Firebase Admin initialization
- Production environment maintains existing functionality
- Development environment unaffected (was working correctly)

BENEFITS:
✅ Subscription sync-status now works in preview environment
✅ All Firebase Admin API routes use consistent initialization pattern
✅ Better error handling when Firebase Admin unavailable
✅ Prevents similar issues in future API routes

This fixes the preview environment subscription errors and ensures robust Firebase Admin usage! 🎉🔧

Author: sirjamesgray

app/api/admin/analytics-data/route.ts

@@ -10,7 +10,11 @@ export async function GET(request: NextRequest) {
       return NextResponse.json({ error: permissionCheck.error }, { status: 401 });
     }
 
-    const { adminDb } = getFirebaseAdmin();
+    const admin = getFirebaseAdmin();
+    if (!admin) {
+      return NextResponse.json({ error: 'Firebase Admin not available' }, { status: 500 });
+    }
+    const adminDb = admin.firestore();
 
     const { searchParams } = new URL(request.url);
     const type = searchParams.get('type');

app/api/auth/login/route.ts

@@ -117,7 +117,12 @@ export async function POST(request: NextRequest) {
     }
 
     // Production mode: use Firebase Auth
-    const { auth, firestore } = getFirebaseAdmin();
+    const admin = getFirebaseAdmin();
+    if (!admin) {
+      return NextResponse.json({ error: 'Firebase Admin not available' }, { status: 500 });
+    }
+    const auth = admin.auth();
+    const firestore = admin.firestore();
 
     // Determine if input is email or username
     const isEmail = emailOrUsername.includes('@');

app/api/dev/setup-test-allocations/route.ts

@@ -10,7 +10,11 @@ import { getFirebaseAdmin } from '../../../firebase/admin';
 import { getCollectionName } from '../../../utils/environmentConfig';
 import { DEV_TEST_USERS } from "../../../utils/testUsers";
 
-const { db } = getFirebaseAdmin();
+const admin = getFirebaseAdmin();
+if (!admin) {
+  throw new Error('Firebase Admin not available');
+}
+const db = admin.firestore();
 
 // Check if development auth is active
 const isDevelopmentAuthActive = () => {

app/api/subscription/sync-status/route.ts

@@ -21,7 +21,13 @@ export async function POST(request: NextRequest) {
 
     console.log(`[SUBSCRIPTION SYNC] Syncing subscription status for user ${userId}`);
 
-    const { adminDb } = getFirebaseAdmin();
+    const admin = getFirebaseAdmin();
+    if (!admin) {
+      console.error('[SUBSCRIPTION SYNC] Firebase Admin not available');
+      return NextResponse.json({ error: 'Firebase Admin not available' }, { status: 500 });
+    }
+
+    const adminDb = admin.firestore();
     const { parentPath, subCollectionName } = getSubCollectionPath(
       PAYMENT_COLLECTIONS.USERS,
       userId,