Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-active Bullet_Resistance when Armor's durability is 0 #8

Open
ASTRICKK opened this issue Oct 30, 2022 · 2 comments
Open

De-active Bullet_Resistance when Armor's durability is 0 #8

ASTRICKK opened this issue Oct 30, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@ASTRICKK
Copy link

ASTRICKK commented Oct 30, 2022

Description

https://cdn.discordapp.com/attachments/940673459585966121/1036291057031319602/Desktop_2022.10.30_-_21.41.59.06.mp4
In this video will show about WeaponMechanics's bug. It won't destroy any armor, but I love this bug.
1.Is there any possible to make the armor can't be destroy but we could reduce the durability from max to 0? but it can't be destroyed.
2. And my feature is when durability of armor is 0. Bullet_Resistance will not active. Is it possible?

  • [Yes ] I'm willing to pay for this feature

Configuration

Armor_A:
  Type: NETHERITE_CHESTPLATE
  Durability: 1
  Will_not_destroyed: true
  Bonus_Effects:
    Bullet_Resistance:
        Base: 0.5
        Will_not_active_when_durability_is_0: true
@ASTRICKK ASTRICKK added the enhancement New feature or request label Oct 30, 2022
@CJCrafter
Copy link
Member

I'll have to figure out what causes the bug before I can make any promises

@CJCrafter
Copy link
Member

After looking into this a bit, I think the best way to implement this feature is to implement a custom durability system, as described by #5. Basically, instead of using Minecraft's built-in durability system, I would add a number tracking each armor piece's durability.

Armor_A:
  Custom_Durability:
    Count_Towards_Sets_When_Broken: <true/false>  # used for disabling full set bonus effects
    Keep_Item_When_Broken: <true/false>  #  
    Broken_Item: <ItemSerializer>  # used to replace the main armor with a "broken" or "less effective" piece of armor
    Max_Durability: <Integer>
    Show_Vanilla_Durability: <true/false>
    Calculate_Unbreaking_Enchantment: <true/false>
    Lose_Durability_Mechanics: <Mechanics>

    # The next issue is repairing. For admins, I'll add `/am fix <player>` to fully repair all ArmorMechanics
    # armors in the inventory. For normal players, I'll add:
    Durability_Per_Exp: <Integer>  # like mending from vanilla
    Repair_Items:  # in anvil or repair station
      Item_0: <ItemSerializer>
        Durability_Per_Item: <Integer>

this is a rather complicated set of features, and it will require me to do a lot of testing to ensure there are no issues, like item duplication. For this reason, I'll give you 2 different quotes:

$65 for everything

OR

$50 for everything except the repair system

If this is acceptable to you, here is my paypal link. Make sure to send me a message afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants