Test `claim_winnings` with zero total winnings share

[Yunusabdul38]

Test claim_winnings with zero total winnings share

Dependencies

• Dependency: None

Description

If the winning outcome has a very small total stake compared to the protocol fee, it's possible for some users to receive 0 winnings.

Requirements

• Set up a pool where the protocol fee is large enough that after deduction, the payout pool for a very small winning stake might result in 0.
• Verify claim_winnings returns 0 and doesn't crash or underflow.

Task for Contributor

• Implement the requested changes.
• Crucial: Write comprehensive unit or integration tests to verify your implementation.
• Ensure all tests pass and the code is properly formatted.

Verification

• Contributor must ensure GitHub CI checks pass.
• Verify the WinningsClaimedEvent is still emitted with 0 amount.

[drips-wave]

This issue has been added to the Stellar Wave Program and is worth 200 Points.

🧑‍💻 Interested in contributing? Apply to work on this issue on Drips Wave, earn points, and receive rewards.

Warning

Only applications submitted via the apply link above will be considered. Please do not apply by commenting on the issue or opening a PR directly.

🤠 Repo maintainers: You can manage this issue's Points and Complexity on your Maintainer Dashboard here. Please keep an eye on applications and respond quickly 💙

ℹ️ Learn more about Drips Wave

[Danto1606]

@Danto1606 has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

I would like to work on this please

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Danto1606 to this issue.

[drips-wave]

Congratulations, @Danto1606! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on March 30, 2026.

🧑‍💻 @Danto1606: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been marked as completed by a Drips Wave moderator for @Danto1606 as part of the Stellar Wave Program's 3rd Wave 🥳

Moderator's reason: [Auto-assessed] The contributor successfully implemented the requested test case in PR #479, which directly addresses the scenario of zero winnings due to small stakes and fees. The PR has been merged by the maintainers, confirming the contribution is accepted.

😎 @Danto1606: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

ℹ️ Note: This issue was marked complete via moderation. Points were issued even though the GitHub issue remains open.