Skip to content

Commit f3161d2

Browse files
fix: address code review comments
Signed-off-by: Victor Adossi <[email protected]>
1 parent 7701389 commit f3161d2

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

design/mvp/WIT.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1028,13 +1028,13 @@ Assume the following WIT package as the initial interface:
10281028
```wit
10291029
package examples:[email protected];
10301030
1031-
variant calc-error {
1032-
integer-overflow,
1033-
integer-underflow,
1034-
unexpected,
1035-
}
1036-
10371031
interface calc {
1032+
variant calc-error {
1033+
integer-overflow,
1034+
integer-underflow,
1035+
unexpected,
1036+
}
1037+
10381038
add: func(x: i32, y: i32) -> result<i32, calc-error>;
10391039
}
10401040
```
@@ -1057,7 +1057,7 @@ interface calc {
10571057
}
10581058
```
10591059

1060-
At this point, consumers of the WIT can enable feature `minus` through their relevant tooling and get access to the `sub` function.
1060+
At this point, consumers of the WIT can enable feature `fgates-calc-minus` through their relevant tooling and get access to the `sub` function.
10611061

10621062
Note that if we had to *add* a new variant to `calc-error`, this would be a *breaking change* for most if not all downstream bindgen tooling (i.e. the enum would become a new object, incompatible with previous code).
10631063

@@ -1087,13 +1087,13 @@ Assume the following WIT package as the initial interface:
10871087
```wit
10881088
package examples:[email protected];
10891089
1090-
variant calc-error {
1091-
integer-overflow,
1092-
integer-underflow,
1093-
unexpected,
1094-
}
1095-
10961090
interface calc {
1091+
variant calc-error {
1092+
integer-overflow,
1093+
integer-underflow,
1094+
unexpected,
1095+
}
1096+
10971097
add-one: func(x: i32) -> result<i32, calc-error>;
10981098
10991099
@since(version = 0.1.1)

0 commit comments

Comments
 (0)