Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some SO_* constants like SO_BROADCAST and SO_LINGER aren't defined #531

Open
nickrum opened this issue Aug 30, 2024 · 2 comments · May be fixed by #533
Open

Some SO_* constants like SO_BROADCAST and SO_LINGER aren't defined #531

nickrum opened this issue Aug 30, 2024 · 2 comments · May be fixed by #533

Comments

@nickrum
Copy link

nickrum commented Aug 30, 2024

While WASI does not (yet) support UDP broadcast or TCP linger, it would still be useful if these constants were defined, similar to how all the IP_*, IPV6_* and TCP_* constants are defined, even though WASI doesn't support all the related functionality.

Specifically, this came up while adding socket support to the Rust wasm32-wasip2 target. Since the part of the implementation that is common to all targets makes use of these constants, adding them to wasi-libc would allow this to be done without introducing conditional compilation to the common implementation.

@abrown
Copy link
Collaborator

abrown commented Sep 3, 2024

This makes sense; are you interested in adding these? (cc: @badeend, @dicej)

@nickrum
Copy link
Author

nickrum commented Sep 9, 2024

Sure, I'll give it a shot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants