Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Monaco tests from GrandPrix #5

Open
bgrins opened this issue Jul 15, 2022 · 1 comment
Open

Import Monaco tests from GrandPrix #5

bgrins opened this issue Jul 15, 2022 · 1 comment
Labels
non-trivial change A change that affects benchmark results v4

Comments

@bgrins
Copy link
Contributor

bgrins commented Jul 15, 2022

Consensus from @rniwa and @kyliau that Monaco-Editor and Monaco-Syntax-Highlight should come over. Also worth considering when doing the work if there are useful test runner changes to bring over.
@bgrins bgrins mentioned this issue Feb 25, 2023
Merged
bgrins pushed a commit to mozilla/Speedometer that referenced this issue May 4, 2023
@lpardosixtosMs
Merge pull request WebKit#5 from lpardosixtosMs/issackjohn/Nits
8962a75 
Nits
@bgrins bgrins added the v4 label May 19, 2023
@bgrins
Copy link
Contributor Author

bgrins commented May 19, 2023

Marking as out of scope for 3 since it depends on async steps (#83)

@bgrins bgrins added the non-trivial change A change that affects benchmark results label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
non-trivial change A change that affects benchmark results v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bgrins