fix: defer bulk-import re-ID until all detections terminal#1552
Open
JasonWildMe wants to merge 6 commits intomainfrom
Open
fix: defer bulk-import re-ID until all detections terminal#1552JasonWildMe wants to merge 6 commits intomainfrom
JasonWildMe wants to merge 6 commits intomainfrom
Conversation
Bulk imports fire per-encounter identification immediately after each detection callback, before sibling encounters finish detection. This causes intra-bulk matches to be missed on the first pass because WBIA's matching index doesn't yet include annotations from unfinished siblings. Branch processCallback: when a detection callback belongs to a bulk import (importTaskId in task parameters), defer identification. On each callback, check if ALL ImportTask MediaAssets have terminal detection status. Only the last terminal callback—claimed atomically via a JVM-global registry keyed on importTaskId plus a persistent flag on the root IA Task for restart survival—fires a single bulk-final ID pass over all eligible annotations (matchAgainst && validForIdentification), grouped by encounter with location filters. Non-bulk detection-then-identify path is unchanged (refactored into helpers but identical behavior). 24 new unit tests covering registry atomicity, bulk task detection, encounter grouping, and terminal status checking. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1552 +/- ##
=======================================
Coverage 51.61% 51.61%
=======================================
Files 308 308
Lines 11976 11976
Branches 3856 3847 -9
=======================================
Hits 6182 6182
- Misses 5507 5514 +7
+ Partials 287 280 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@naknomum For your approval when you return! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
processCallbackfor bulk imports: defer identification until all ImportTask MediaAssets have terminal detection status (complete|pending|error), then fire one bulk-final ID pass over ALL eligible annotations, claimed atomically via JVM-global registry + persistent Task flag for restart survival.Architecture
Files changed
BulkFinalIdentificationRegistry.javaTask.javabulkFinalIdentificationFiredBooleanpackage.jdoImportTask.javaisAllDetectionTerminal()helperIBEISIA.javaTest plan
mvn testpasses (11 pre-existing errors in Settings/ShepherdState tests unrelated to this change)mvn compilecleanINFO: fireBulkFinalIdentificationIfReady: ImportTask X -> ID on N annotations across M encounters🤖 Generated with Claude Code