Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.4 #109

Open
michelesr opened this issue May 3, 2019 · 13 comments
Open

Release 0.4 #109

michelesr opened this issue May 3, 2019 · 13 comments
Milestone

Comments

@michelesr
Copy link
Contributor

Recently nvidia-xrun introduced a series of breaking changes, for example the new configuration file and the other changes introduced by merging nvidia-xrun-pm PR.

This means that a new (possibly major) version needs to be released and possibly package specs needs to be updated as well. The RPM spec seems to be quite outdated, maybe @ekultails can help with this (in fact it did the same for nvidia-xrun-pm but I didn't merge the changes as I wasn't sure of the current status of the nvidia-xrun repositories). Also is questionable whether is a good thing to maintain the RPM spec into the repository, maybe it can be moved out and maintained separately.

Once this is issues is closed nvidia-xrun-pm can be safely archived.

@michelesr michelesr changed the title Breaking changes and new release (and package specs) Breaking changes and new release May 3, 2019
@LukeShortCloud
Copy link
Contributor

This is fantastic news that nvidia-xrun-pm finally got merged in!

Sometime this weekend I will take my RPM spec I have been working on from your fork, place it in a separate GitHub repository, and update it to now use the upstream nvidia-xrun.

@LukeShortCloud
Copy link
Contributor

I would also like to note that we should remove the RPM spec from this repository entirely, update the README documentation to point to my COPR (I will create a new one that will also support EL/Fedora/openSUSE), and then @Witko should tag a new nvidia-xrun release (0.4? 1.0?) on GtiHub. I would personally say this should be a 1.0 release to indicate the breaking changes.

I will sent a PR to help with the first two steps.

@michelesr
Copy link
Contributor Author

michelesr commented May 3, 2019

@ekultails what about the other repositories in COPR? Are they still maintained? (@AxelSilverdew)

Regarding the version number I'm not sure that semantic versioning is used here, so it could also be a minor release, as usually 1 marks something that is quite stable. All of this decisions are to be made by @Witko really, so let's wait for him to anwser and see.

@LukeShortCloud
Copy link
Contributor

The original axeld COPR repository mentioned in the README is no longer maintained and does not have any packages. The other repository myrgy on COPR is only for Fedora 28 and the last build was from 10 months ago and it failed. I have the latest builds enabled for all non-EOL RPM based operating systems.

I understand that versioning is out of my control, my opinion is that semantic versioning should be used. Changing the version scheme now would be a good time, too, considering the last tagged version was 0.3 from 3 years ago.

@LukeShortCloud
Copy link
Contributor

@Witko @michelesr I opened up a PR to remove the spec file. My updated spec now handles building RPMs based on the git commit hash as to avoid the need to wait on new GitHub tags. I also published builds for all RPM based distributions (including Mageia, which I had missed with nvidia-xrun-pm). All of the relevant details are in the commit message and README updates.

Let me know if you need anything else from my end.

@michelesr
Copy link
Contributor Author

@ekultails great, if users have a way to install the new code without a release it's even better! In Arch Linux the nvidia-xrun-git package can be used to install from master branch, so I guess we can safely archive the fork once this is merged.

@Witko
Copy link
Owner

Witko commented May 6, 2019

Hi guys, i've merged the spec removal. Now i need to get my laptop working with nvidia card and then review the whole thing. And then a release would be nice.

@Witko Witko pinned this issue May 6, 2019
@Witko Witko added this to the Version 0.4.0 milestone May 6, 2019
@Witko Witko changed the title Breaking changes and new release Release 0.4 May 6, 2019
@Witko
Copy link
Owner

Witko commented May 6, 2019

I've added few issues i'd like to incorporate or at least consider for 0.4

@skoehler
Copy link

I can't find any reference in nvidia-run to bbswitch anymore. Is it not supported anymore? The method via /sys/bus/pci/*/power/control didn't even work for me when I last tried. Why don't you auto detect the presence of bbswitch and use bbswitch if present. That way, 0.4 wouldn't break working setups for people who use bbswitch.

I'm using a Dell XPS 9560.

@michelesr
Copy link
Contributor Author

michelesr commented Jun 22, 2019 via email

@skoehler
Copy link

skoehler commented Jun 22, 2019

I had pcie_port_pm=off in my kernel command line, because without it I would have problems. Since I have added that eons ago, I hope newer kernels fix the issues. TURN_OFF_GPU_ONLY=1 nvidia-xrun seems to work now and even survives a suspend to RAM cycle. I'm also using Arch Linux.

@Yutsuten
Copy link

I'm very hype for this release, hope I can see it soon!

@osleg
Copy link

osleg commented Oct 23, 2019

Asus UX480FD here, without bbswitch it doesn't ever turn off the GPU with and without PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants