Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: TS type definitions not updated for new strictCheck option #19

Open
markmsmith opened this issue Jan 8, 2020 · 0 comments
Open

Comments

@markmsmith
Copy link

This PR added a new configuration option of strictCheck to codependency.register(). Unfortunately, the type definitions here weren't also updated with the new option, causing type checking errors for Typescript users of the library that try to use this option.

It looks like the original type definitions were created by someone else, but I thought you should have a heads-up on this issue, since it makes it harder for people to use your library.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant