Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: サイドバーのウィンドウ固定化 #1004

Open
sor4chi opened this issue Aug 17, 2023 · 0 comments · May be fixed by #1006
Open

fix: サイドバーのウィンドウ固定化 #1004

sor4chi opened this issue Aug 17, 2023 · 0 comments · May be fixed by #1006
Assignees
@okakyo
Labels
⚠️ bug: design デザインのバグ修正 🔽 Low Priority このラベルがついているissueは緊急度が低めです

Comments

@sor4chi
Copy link
Contributor

sor4chi commented Aug 17, 2023 •
edited
Loading

機能追加理由・詳細

Before After
スクリーンショット 2023-08-17 15 16 41 スクリーンショット 2023-08-17 15 16 23
2023-08-17.15.16.45.mov
2023-08-17.15.17.38.mov

解決策の提案（任意）
Sidebarのコンテナのposition: stickyをposition: fixedへ

ContentsコンテナがWizUIから提供されてないので提供する
そのContentsコンテナはmt=60px (ヘッダ幅), ml=181px(サイド幅 + ボーダー1px)を持った<main>か<div>でいいと思う

その他考慮事項（任意）

現状

    <WizStack reverse height="100vh">
      <Gradient />
      <div style={{ display: 'flex', width: '100%', zIndex: '0' }}>
        <Navigation isNavigationOpen={isNavigationOpen} />
        <WizBox width="100%">
          <div style={{ paddingTop: '61px' }}>
            <Outlet />
          </div>
        </WizBox>
      </div>
      <Header onToggle={handleToggleHeader} />
    </WizStack>

改善提案

    <WizStack reverse height="100vh">
      <Gradient />
      <Navigation isNavigationOpen={isNavigationOpen} />
      <WizMainContainer>
        <Outlet />
      </WizMainContainer>
      <Header onToggle={handleToggleHeader} />
    </WizStack>
@sor4chi sor4chi added the ⚠️ bug: design デザインのバグ修正 label Aug 17, 2023
@ichi-h ichi-h moved this to 開発待ち in wiz-ui進捗管理 Aug 17, 2023
@ichi-h ichi-h added the 🔽 Low Priority このラベルがついているissueは緊急度が低めです label Aug 17, 2023
okakyo added a commit that referenced this issue Aug 17, 2023
@okakyo
[#1004] fix: sticky をfixed に変更
12d215d
@okakyo okakyo linked a pull request Aug 17, 2023 that will close this issue
Open
okakyo added a commit that referenced this issue Aug 20, 2023
@okakyo
[#1004] NavigationContent 追加
e4f4898
@ichi-h ichi-h moved this from 開発待ち to レビュー待ち in wiz-ui進捗管理 Aug 22, 2023
okakyo added a commit that referenced this issue Aug 22, 2023
@okakyo
[#1004] NavigationContent 追加
19f0489
okakyo added a commit that referenced this issue Aug 22, 2023
@okakyo
[#1004] React 対応
d97ac74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@okakyo okakyo

Labels
⚠️ bug: design デザインのバグ修正 🔽 Low Priority このラベルがついているissueは緊急度が低めです
Projects
wiz-ui進捗管理
Status: レビュー待ち
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: サイドバーのウィンドウ固定化 Wizleap-Inc/wiz-ui
3 participants
@okakyo @sor4chi @ichi-h