Emulation improvement general thread

[freq-mod]

I don't know if it's the correct place for requesting this, or should I open the new issue ticket, but:

Gens 2.10 can be removed. Rationale:

• Right now, there are already six emulators to select from. For such an utility, it's beyond excessive. For comparison, Bamboo Tracker has only two options (MAME YM2608 and Nuked OPN-Mod)
• It's ridiculously broken. Synthesis rate is incorrect. ADSR envelopes don't have the correct length, key features like SSG-EG don't work.
• While it's true Gens is lightweight, MAME 2612 or NP2 fmgen aren't so resource hungry at all, fmgen is only marginally slower than Gens iirc. I don't know any device that wouldn't handle three NP2 FM cores.

I can open a PR removing Gens emu completely if you agree.

[Wohlstand]

GENS 2.10 I would replace with it's the newer version that has better support for SSG-EG (once upon I tried to play Asterix&Obelix game on some random GENS version, and music played almost properly, not hellish-dirty)

[freq-mod]

You mean Gens GS/II? I also remember it being better in terms of accuracy

[Wohlstand]

GENS emulator at least has one proc that it has the best performance in comparison to others. Anyway, Idk what about the newer GENS version against ADSR, and that I know.

[freq-mod]

@Wohlstand I actually test updated Gens core and it really works much better, while far from perfect, it still is very fast.

I can open a PR for that. Only problem - panning doesn't seem to work.

[Wohlstand]

panning doesn't seem to work.

That because of a soft-panning that isn't at the new core, it's a custom quirk that should be backported.

[Wohlstand]

Okay, right now OPN2-BE has the updated GENS GS/II chip emulator. Now I should try to add the updated MAME emulator with a BSD license. If it will work fine, I'll also commit it to the GME library.

[freq-mod]

Regarding that new MAME emu:

Mixing is done per-chip, and DAC limitations are now implemented where understood. This means, for example, that the YM2612 now mixes down to 9-bit resolution and has a discontinuity at 0.

So, this new thing can also replace Genesis Plus GX core as well 👀
Still, it is being improved, mainly performace wise, so it's better to not rush it just yet.

[Wohlstand]

At the first, I'll add the new MAME emulator as a separated chip, and if it will work better, I'll nuke the old one. The Genesis Plus GX is mainly here because it simulates the ladder effect, however, for me, it's a bit buggy and may not play some notes, I have some examples of that.

[Wohlstand]

Damn at libOPNMIDI!

( Showing only the last 30 out of 39 lines. For a complete log visit the build page )


        ../src/chips/gens/Ym2612_p.hpp:210:41: error: floating-point literal cannot appear in a constant-expression
   static const int PG_CUT_OFF = ((int) (78.0 / ENV_STEP));
                                         ^
../src/chips/gens/Ym2612_p.hpp:192:21: error: floating-point literal cannot appear in a constant-expression
   #define ENV_STEP (96.0 / ENV_LENGTH) // ENV_MAX = 96 dB
                     ^
../src/chips/gens/Ym2612_p.hpp:210:48: note: in expansion of macro ‘ENV_STEP’
   static const int PG_CUT_OFF = ((int) (78.0 / ENV_STEP));
                                                ^
../src/chips/gens/Ym2612_p.hpp:211:42: error: floating-point literal cannot appear in a constant-expression
   static const int ENV_CUT_OFF = ((int) (68.0 / ENV_STEP));
                                          ^
../src/chips/gens/Ym2612_p.hpp:192:21: error: floating-point literal cannot appear in a constant-expression
   #define ENV_STEP (96.0 / ENV_LENGTH) // ENV_MAX = 96 dB
                     ^
../src/chips/gens/Ym2612_p.hpp:211:49: note: in expansion of macro ‘ENV_STEP’
   static const int ENV_CUT_OFF = ((int) (68.0 / ENV_STEP));
                                                 ^
../src/chips/gens/Ym2612_p.hpp:220:43: error: floating-point literal cannot appear in a constant-expression
   static const int LFO_FMS_BASE = ((int) (0.05946309436 * 0.0338 * (double) (1 << LFO_FMS_LBITS)));
                                           ^
../src/chips/gens/Ym2612_p.hpp:220:59: error: floating-point literal cannot appear in a constant-expression
   static const int LFO_FMS_BASE = ((int) (0.05946309436 * 0.0338 * (double) (1 << LFO_FMS_LBITS)));
                                                           ^
../src/chips/gens/Ym2612_p.hpp:220:96: error: a cast to a type other than an integral or enumeration type cannot appear in a constant-expression
   static const int LFO_FMS_BASE = ((int) (0.05946309436 * 0.0338 * (double) (1 << LFO_FMS_LBITS)));
                                                                                                ^

[11/77] Building CXX object CMakeFiles...I_shared.dir/src/opnmidi_private.cpp.o
[11/77] Building CXX object CMakeFiles...MIDI_shared.dir/src/opnmidi_opn2.cpp.o
[11/77] Building CXX object CMakeFiles...MIDI_shared.dir/src/opnmidi_load.cpp.o
[11/77] Building CXX object CMakeFiles/OPNMIDI_shared.dir/src/opnmidi.cpp.o
[11/77] Building C object CMakeFiles/O...d.dir/src/chips/mame/mame_ym2612fm.c.o
[11/77] Building CXX object CMakeFiles..._shared.dir/src/opnmidi_midiplay.cpp.o
[11/77] Building CXX object CMakeFiles...shared.dir/src/opnmidi_sequencer.cpp.o
ninja: build stopped: subcommand failed.

      

.... 🤔
Goint to fix...

[Wohlstand]

( Showing only the last 30 out of 33 lines. For a complete log visit the build page )


         #define LOG_MSG(...)
                 ^
In file included from ../src/chips/gens/Ym2612.cpp:37:0:
../src/chips/gens/Ym2612_p.hpp:208:62: error: floating-point literal cannot appear in a constant-expression
   static const int LIMIT_CH_OUT = ((int) (((1 << OUT_BITS) * 1.5) - 1));
                                                              ^
../src/chips/gens/Ym2612.cpp:126:1: warning: narrowing conversion of ‘LibGens::Ym2612Private::LFO_FMS_BASE’ from ‘int’ to ‘const uint8_t {aka const unsigned char}’ inside { } is ill-formed in C++11 [-Wnarrowing]
 };
 ^
../src/chips/gens/Ym2612.cpp:123:15: warning: narrowing conversion of ‘(LibGens::Ym2612Private::LFO_FMS_BASE * 2)’ from ‘int’ to ‘const uint8_t {aka const unsigned char}’ inside { } is ill-formed in C++11 [-Wnarrowing]
  LFO_FMS_BASE * 2, LFO_FMS_BASE * 3,
               ^
../src/chips/gens/Ym2612.cpp:123:33: warning: narrowing conversion of ‘(LibGens::Ym2612Private::LFO_FMS_BASE * 3)’ from ‘int’ to ‘const uint8_t {aka const unsigned char}’ inside { } is ill-formed in C++11 [-Wnarrowing]
  LFO_FMS_BASE * 2, LFO_FMS_BASE * 3,
                                 ^
../src/chips/gens/Ym2612.cpp:124:15: warning: narrowing conversion of ‘(LibGens::Ym2612Private::LFO_FMS_BASE * 4)’ from ‘int’ to ‘const uint8_t {aka const unsigned char}’ inside { } is ill-formed in C++11 [-Wnarrowing]
  LFO_FMS_BASE * 4, LFO_FMS_BASE * 6,
               ^
../src/chips/gens/Ym2612.cpp:124:33: warning: narrowing conversion of ‘(LibGens::Ym2612Private::LFO_FMS_BASE * 6)’ from ‘int’ to ‘const uint8_t {aka const unsigned char}’ inside { } is ill-formed in C++11 [-Wnarrowing]
  LFO_FMS_BASE * 4, LFO_FMS_BASE * 6,
                                 ^
../src/chips/gens/Ym2612.cpp:125:15: warning: narrowing conversion of ‘(LibGens::Ym2612Private::LFO_FMS_BASE * 12)’ from ‘int’ to ‘const uint8_t {aka const unsigned char}’ inside { } is ill-formed in C++11 [-Wnarrowing]
  LFO_FMS_BASE * 12, LFO_FMS_BASE * 24
               ^
../src/chips/gens/Ym2612.cpp:125:34: warning: narrowing conversion of ‘(LibGens::Ym2612Private::LFO_FMS_BASE * 24)’ from ‘int’ to ‘const uint8_t {aka const unsigned char}’ inside { } is ill-formed in C++11 [-Wnarrowing]
  LFO_FMS_BASE * 12, LFO_FMS_BASE * 24
                                  ^

[10/77] Building CXX object CMakeFiles...I_shared.dir/src/chips/mame_opn2.cpp.o
[10/77] Building CXX object CMakeFiles...I_shared.dir/src/opnmidi_private.cpp.o
[10/77] Building CXX object CMakeFiles...MIDI_shared.dir/src/opnmidi_opn2.cpp.o
[10/77] Building CXX object CMakeFiles...MIDI_shared.dir/src/opnmidi_load.cpp.o
[10/77] Building CXX object CMakeFiles/OPNMIDI_shared.dir/src/opnmidi.cpp.o
[10/77] Building CXX object CMakeFiles..._shared.dir/src/opnmidi_midiplay.cpp.o
[10/77] Building CXX object CMakeFiles...shared.dir/src/opnmidi_sequencer.cpp.o
ninja: build stopped: subcommand failed.

🤔 🤔 🤔 🤔 🤔 🤔 🤔 🤔 🤔 🤔 🤔 🤔

[Wohlstand]

Phew, fixed that, backporting into OPN2-BE back.