-
Notifications
You must be signed in to change notification settings - Fork 504
Open
Milestone
Description
As per #595:
The methods covered via the
DecompressionTest
test class need a lot more tests, in particular theRequests::compatible_gzinflate()
method, which includes code paths currently completely untested and handling of ZIP file format, which when called fromRequests::decompress()
(which is the only way it is called from within the Requests library itself), can never be reached as the "magic markers" used by ZIP are not included in theRequests::$magic_compression_headers
property.A future iteration should do a more in-depth review of these two method to determine what should be handled by each method and add additional tests.