Revert how the sniff handles namespaced functions that mirror the name of WP global cache functions

As discussed during the PR review, this reverts changes from the previous commit which filtered out namespaced cache function calls. After discussion, it was decided to maintain the existing behavior where namespaced cache functions like `MyNamespace\wp_cache_get()` are treated as valid custom cache implementations, consistent with how method calls like `$obj->wp_cache_get()` are handled.

The tests have been updated to test the new behavior.

Author: rodrigoprimo

WordPress/Sniffs/DB/DirectDatabaseQuerySniff.php

@@ -235,15 +235,6 @@ public function process_token( $stackPtr ) {
 						continue;
 					}
 
-					// Skip if this is a non-global namespaced function call.
-					$prevNonEmpty = $this->phpcsFile->findPrevious( Tokens::$emptyTokens, ( $i - 1 ), null, true );
-					if ( \T_NS_SEPARATOR === $this->tokens[ $prevNonEmpty ]['code'] ) {
-						$prevPrevNonEmpty = $this->phpcsFile->findPrevious( Tokens::$emptyTokens, ( $prevNonEmpty - 1 ), null, true );
-						if ( \T_STRING === $this->tokens[ $prevPrevNonEmpty ]['code'] || \T_NAMESPACE === $this->tokens[ $prevPrevNonEmpty ]['code'] ) {
-							continue;
-						}
-					}
-
 					$content = strtolower( $this->tokens[ $i ]['content'] );
 
 					if ( isset( $this->cacheDeleteFunctions[ $content ] ) ) {

WordPress/Tests/DB/DirectDatabaseQueryUnitTest.1.inc

@@ -398,28 +398,56 @@ function fullyQualifiedCallsToCacheFunctions2() {
 	\wp_cache_delete( 'key', 'group' );
 }
 
-function callToNamespacedNonGlobalFunctions1() {
+function callToQualifiedNamespacedCacheGetSet() {
 	global $wpdb;
 
-	$listofthings = MyNamespace\wp_cache_get( $foo );
-	$listofthings = \MyNamespace\wp_cache_get( $foo );
-	$listofthings = namespace\wp_cache_get( $foo ); // The sniff should start considering this a valid WP cache function once it can resolve relative namespaces.
-
-	if ( ! $listofthings ) {
-		$listofthings = $wpdb->get_col( 'SELECT something FROM somewhere WHERE someotherthing = 1' ); // Warning x 2.
+	if ( ! ( $listofthings = MyNamespace\wp_cache_get( $foo ) ) ) {
+		$listofthings = $wpdb->get_col( 'SELECT something FROM somewhere WHERE someotherthing = 1' ); // Warning direct DB call.
 		MyNamespace\wp_cache_set( 'foo', $listofthings );
+	}
+
+	return $listofthings;
+}
+
+function callToFullyQualifiedNamespacedCacheGetSet() {
+	global $wpdb;
+
+	if ( ! ( $listofthings = \MyNamespace\wp_cache_get( $foo ) ) ) {
+		$listofthings = $wpdb->get_col( 'SELECT something FROM somewhere WHERE someotherthing = 1' ); // Warning direct DB call.
 		\MyNamespace\wp_cache_set( 'foo', $listofthings );
-		namespace\wp_cache_set( 'foo', $listofthings ); // The sniff should start considering this a valid WP cache function once it can resolve relative namespaces.
 	}
 
 	return $listofthings;
 }
 
-function callToNamespacedNonGlobalFunctions2() {
+function callToRelativeNamespacedCacheGetSet() {
 	global $wpdb;
 
-	$wpdb->query( 'SELECT X FROM Y' ); // Warning x 2.
+	if ( ! ( $listofthings = namespace\wp_cache_get( $foo ) ) ) {
+		$listofthings = $wpdb->get_col( 'SELECT something FROM somewhere WHERE someotherthing = 1' ); // Warning direct DB call.
+		namespace\wp_cache_set( 'foo', $listofthings );
+	}
+
+	return $listofthings;
+}
+
+function callToQualifiedNamespacedCacheDelete() {
+	global $wpdb;
+
+	$wpdb->query( 'SELECT X FROM Y' ); // Warning direct DB call.
 	MyNamespace\wp_cache_delete( 'key', 'group' );
+}
+
+function callToFullyQualifiedNamespacedCacheDelete() {
+	global $wpdb;
+
+	$wpdb->query( 'SELECT X FROM Y' ); // Warning direct DB call.
 	\MyNamespace\wp_cache_delete( 'key', 'group' );
-	namespace\wp_cache_delete( 'key', 'group' ); // The sniff should start considering this a valid WP cache function once it can resolve relative namespaces.
+}
+
+function callToRelativeNamespacedCacheDelete() {
+	global $wpdb;
+
+	$wpdb->query( 'SELECT X FROM Y' ); // Warning direct DB call.
+	namespace\wp_cache_delete( 'key', 'group' );
 }

WordPress/Tests/DB/DirectDatabaseQueryUnitTest.php

@@ -101,8 +101,12 @@ public function getWarningList( $testFile = '' ) {
 					376 => 1,
 					387 => 1,
 					397 => 1,
-					409 => 2,
-					421 => 2,
+					405 => 1,
+					416 => 1,
+					427 => 1,
+					437 => 1,
+					444 => 1,
+					451 => 1,
 				);
 			default:
 				return array();