WP/EnqueuedResourceParameters: handle fully qualified \false and \null correctly

Before this change passing `\false` or `\null` as the `$ver` parameter would result in a false negative.

Author: rodrigoprimo

WordPress/Sniffs/WP/EnqueuedResourceParametersSniff.php

@@ -53,14 +53,15 @@ final class EnqueuedResourceParametersSniff extends AbstractFunctionParameterSni
 	);
 
 	/**
-	 * False + the empty tokens array.
+	 * False + T_NS_SEPARATOR + the empty tokens array.
 	 *
 	 * This array is enriched with the $emptyTokens array in the register() method.
 	 *
 	 * @var array<int|string, int|string>
 	 */
 	private $false_tokens = array(
-		\T_FALSE => \T_FALSE,
+		\T_FALSE        => \T_FALSE,
+		\T_NS_SEPARATOR => \T_NS_SEPARATOR, // Needed to handle fully qualified \false (PHPCS 3.x).
 	);
 
 	/**
@@ -140,7 +141,7 @@ public function process_parameters( $stackPtr, $group_name, $matched_content, $p
 			}
 		}
 
-		if ( false === $version_param || 'null' === strtolower( $version_param['clean'] ) ) {
+		if ( false === $version_param || strtolower( ltrim( $version_param['clean'], '\\' ) ) === 'null' ) {
 			$type = 'script';
 			if ( strpos( $matched_content, '_style' ) !== false ) {
 				$type = 'style';

WordPress/Tests/WP/EnqueuedResourceParametersUnitTest.1.inc

@@ -98,3 +98,13 @@ wp_register_script( 'someScript-js', 'https://example.com/someScript.js' , array
 
 // Safeguard handling of non-lowercase `null`.
 wp_register_script( 'someScript-js', 'https://example.com/someScript.js' , array( 'jquery' ), NULL, true ); // Error - 0, false or NULL are not allowed.
+
+/*
+ * Safeguard handling of fully qualified \true, \false and \null.
+ * Also safeguard that adding T_NS_SEPARATOR to $false_tokens doesn't cause false positives due to problems in is_falsy().
+ */
+wp_register_script( 'someScript-js', 'https://example.com/someScript.js' , array( 'jquery' ), \FALSE, true ); // Error - 0, false or NULL are not allowed.
+wp_register_script( 'someScript-js', 'https://example.com/someScript.js' , array( 'jquery' ), \null, true ); // Error - 0, false or NULL are not allowed.
+wp_register_script( 'someScript-js', 'https://example.com/someScript.js' , array( 'jquery' ), \Null, true ); // Error - 0, false or NULL are not allowed.
+wp_register_script( 'someScript-js', 'https://example.com/someScript.js' , array( 'jquery' ), \true, true ); // Ok.
+wp_register_script( 'someScript-js', 'https://example.com/someScript.js' , array( 'jquery' ), \get_version(), true ); // OK.

WordPress/Tests/WP/EnqueuedResourceParametersUnitTest.php

@@ -31,22 +31,23 @@ public function getErrorList( $testFile = '' ) {
 		switch ( $testFile ) {
 			case 'EnqueuedResourceParametersUnitTest.1.inc':
 				return array(
-					6  => 1,
-					9  => 1,
-					10 => 1,
-					12 => 1,
-					13 => 1,
-					14 => 1,
-					22 => 1,
-					54 => 1,
-					57 => 1,
-					61 => 1,
-					82 => 1,
-					85 => 1,
-					89 => 1,
-					92 => 1,
-					95 => 1,
-					97 => 1,
+					6   => 1,
+					9   => 1,
+					10  => 1,
+					12  => 1,
+					13  => 1,
+					14  => 1,
+					22  => 1,
+					54  => 1,
+					57  => 1,
+					61  => 1,
+					82  => 1,
+					85  => 1,
+					89  => 1,
+					92  => 1,
+					95  => 1,
+					97  => 1,
+					106 => 1,
 				);
 
 			case 'EnqueuedResourceParametersUnitTest.2.inc':
@@ -79,6 +80,8 @@ public function getWarningList( $testFile = '' ) {
 					66  => 2,
 					77  => 1,
 					100 => 1,
+					107 => 1,
+					108 => 1,
 				);
 
 			default: