Merge pull request #2581 from rodrigoprimo/add-abstract-function-restrictions-tests

AbstractFunctionRestrictions sniffs: add tests for namespaced names

Author: jrfnl

WordPress/Tests/DB/RestrictedFunctionsUnitTest.inc

@@ -94,3 +94,11 @@ WP_Date_Query::build_mysql_datetime(); // Ok.
 myFictionFunction(); // Bad.
 myFictional(); // OK.
 Myfictional(); // OK.
+
+/*
+ * Safeguard correct handling of all types of namespaced function calls.
+ */
+\mysql_connect();
+MyNamespace\mysql_connect();
+\MyNamespace\mysql_connect();
+namespace\mysql_connect(); // The sniff should start flagging this once it can resolve relative namespaces.

WordPress/Tests/DB/RestrictedFunctionsUnitTest.php

@@ -63,54 +63,56 @@ protected function tearDown(): void {
 	 */
 	public function getErrorList() {
 		return array(
-			25 => 1,
-			26 => 1,
-			27 => 1,
-			28 => 1,
-			29 => 1,
-			30 => 1,
-			31 => 1,
-			32 => 1,
-			33 => 1,
+			25  => 1,
+			26  => 1,
+			27  => 1,
+			28  => 1,
+			29  => 1,
+			30  => 1,
+			31  => 1,
+			32  => 1,
+			33  => 1,
 
-			36 => 1,
-			37 => 1,
-			38 => 1,
-			39 => 1,
-			40 => 1,
-			41 => 1,
-			42 => 1,
-			43 => 1,
-			44 => 1,
+			36  => 1,
+			37  => 1,
+			38  => 1,
+			39  => 1,
+			40  => 1,
+			41  => 1,
+			42  => 1,
+			43  => 1,
+			44  => 1,
 
-			47 => 1,
-			48 => 1,
-			49 => 1,
-			50 => 1,
-			51 => 1,
+			47  => 1,
+			48  => 1,
+			49  => 1,
+			50  => 1,
+			51  => 1,
 
-			54 => 1,
-			55 => 1,
-			56 => 1,
-			57 => 1,
+			54  => 1,
+			55  => 1,
+			56  => 1,
+			57  => 1,
 
-			60 => 1,
+			60  => 1,
 
-			63 => 1,
+			63  => 1,
 
-			66 => 1,
-			67 => 1,
-			68 => 1,
-			69 => 1,
-			70 => 1,
-			71 => 1,
-			72 => 1,
-			73 => 1,
-			74 => 1,
-			75 => 1,
-			76 => 1,
+			66  => 1,
+			67  => 1,
+			68  => 1,
+			69  => 1,
+			70  => 1,
+			71  => 1,
+			72  => 1,
+			73  => 1,
+			74  => 1,
+			75  => 1,
+			76  => 1,
 
-			94 => 1,
+			94  => 1,
+
+			101 => 1,
 		);
 	}
 

WordPress/Tests/DateTime/RestrictedFunctionsUnitTest.inc

@@ -7,3 +7,11 @@ $date->setTimezone( new DateTimeZone( 'America/Toronto' ) ); // Yay!
 
 $post_data['post_title'] = sprintf( __( 'Draft created on %1$s at %2$s' ), date( __( 'F j, Y' ), $now ), date( __( 'g:i a' ), $now ) ); // Error.
 $post_data['post_title'] = sprintf( __( 'Draft created on %1$s at %2$s' ), gmdate( __( 'F j, Y' ), $now ), gmdate( __( 'g:i a' ), $now ) ); // OK.
+
+/*
+ * Safeguard correct handling of all types of namespaced function calls.
+ */
+\date_default_timezone_set( 'Foo/Bar' );
+MyNamespace\date_default_timezone_set( 'Foo/Bar' );
+\MyNamespace\date_default_timezone_set( 'Foo/Bar' );
+namespace\date_default_timezone_set( 'Foo/Bar' ); // The sniff should start flagging this once it can resolve relative namespaces.

WordPress/Tests/DateTime/RestrictedFunctionsUnitTest.php

@@ -27,8 +27,9 @@ final class RestrictedFunctionsUnitTest extends AbstractSniffUnitTest {
 	 */
 	public function getErrorList() {
 		return array(
-			3 => 1,
-			8 => 2,
+			3  => 1,
+			8  => 2,
+			14 => 1,
 		);
 	}
 

WordPress/Tests/PHP/DevelopmentFunctionsUnitTest.inc

@@ -35,5 +35,11 @@ phpinfo(); // Error.
 
 Wrapper_Class::var_dump(); // OK, not the native PHP function.
 $wrapper ->var_dump(); // OK, not the native PHP function.
-namespace\var_dump(); // OK as long as the file is namespaced.
-MyNamespace\var_dump(); // OK, namespaced function.
+
+/*
+ * Safeguard correct handling of all types of namespaced function calls.
+ */
+\var_dump( $value );
+MyNamespace\var_dump( $value );
+\MyNamespace\var_dump( $value );
+namespace\var_dump( $value ); // The sniff should start flagging this once it can resolve relative namespaces.

WordPress/Tests/PHP/DevelopmentFunctionsUnitTest.php

@@ -52,6 +52,7 @@ public function getWarningList() {
 			24 => 1,
 			33 => 1,
 			34 => 1,
+			42 => 1,
 		);
 	}
 }

WordPress/Tests/PHP/DiscouragedPHPFunctionsUnitTest.inc

@@ -1,12 +1,12 @@
 <?php
 
-
-
-
-
-
+// Safeguard against false positives on namespaced function calls.
+MyNamespace\serialize( $value );
+\MyNamespace\serialize( $value );
+namespace\serialize( $value ); // The sniff should start flagging this once it can resolve relative namespaces.
 
 serialize(); // Warning.
+\serialize( $value ); // Warning.
 unserialize(); // Warning.
 
 urlencode(); // Warning.

WordPress/Tests/PHP/DiscouragedPHPFunctionsUnitTest.php

@@ -37,6 +37,7 @@ public function getErrorList() {
 	 */
 	public function getWarningList() {
 		return array(
+			8  => 1,
 			9  => 1,
 			10 => 1,
 			12 => 1,

WordPress/Tests/PHP/DontExtractUnitTest.inc

@@ -7,3 +7,11 @@ my_extract(); // Ok.
 My_Object::extract(); // Ok.
 $this->extract(); // Ok.
 $my_object->extract(); // Ok.
+
+/*
+ * Safeguard correct handling of all types of namespaced function calls.
+ */
+\extract( array( 'a' => 1 ) );
+MyNamespace\extract( array( 'a' => 1 ) );
+\MyNamespace\extract( array( 'a' => 1 ) );
+namespace\extract( array( 'a' => 1 ) ); // The sniff should start flagging this once it can resolve relative namespaces.

WordPress/Tests/PHP/DontExtractUnitTest.php

@@ -29,7 +29,8 @@ final class DontExtractUnitTest extends AbstractSniffUnitTest {
 	 */
 	public function getErrorList() {
 		return array(
-			3 => 1,
+			3  => 1,
+			14 => 1,
 		);
 	}