Merge branch 'trunk' into add/execute-actions

Author: gziolo

CONTRIBUTING.md

@@ -13,9 +13,9 @@ Join the `#core-ai` channel [on WordPress Slack](http://wordpress.slack.com) ([s
 In general, all code must follow the [WordPress Coding Standards and best practices](https://developer.wordpress.org/coding-standards/). All code in the Abilities API plugin must follow these requirements:
 
 - **WordPress**: The plugin's minimum WordPress version requirement is 6.8.
-- **PHP**: The minimum required version of the code slated for WordPress Core includes is PHP7.2, but the tooling and development environment requires PHP 7.4 or higher.
+- **PHP**: The minimum required version of the code slated for WordPress Core includes PHP 7.2, but the tooling and development environment requires PHP 7.4 or higher.
 
-We include [several tools](#useful-commands) to help ensure your code meets contribution
+We include [several tools](#useful-commands) to help ensure your code meets contribution requirements.
 
 ## Guidelines
 

includes/rest-api/endpoints/class-wp-rest-abilities-list-controller.php

@@ -128,13 +128,13 @@ public function get_items( $request ) {
 		if ( $page > 1 ) {
 			$prev_page = $page - 1;
 			$prev_link = add_query_arg( 'page', $prev_page, $base );
-			$response->add_link( 'prev', $prev_link );
+			$response->link_header( 'prev', $prev_link );
 		}
 
 		if ( $page < $max_pages ) {
 			$next_page = $page + 1;
 			$next_link = add_query_arg( 'page', $next_page, $base );
-			$response->add_link( 'next', $next_link );
+			$response->link_header( 'next', $next_link );
 		}
 
 		return $response;

tests/unit/rest-api/wpRestAbilitiesListController.php

@@ -294,33 +294,40 @@ public function test_head_request(): void {
 	 * Test pagination links.
 	 */
 	public function test_pagination_links(): void {
-		// Test first page (should have 'next' link but no 'prev')
+		// Test first page (should have 'next' link header but no 'prev')
 		$request = new WP_REST_Request( 'GET', '/wp/v2/abilities' );
 		$request->set_param( 'per_page', 10 );
 		$request->set_param( 'page', 1 );
 		$response = $this->server->dispatch( $request );
 
-		$links = $response->get_links();
-		$this->assertArrayHasKey( 'next', $links );
-		$this->assertArrayNotHasKey( 'prev', $links );
+		$headers = $response->get_headers();
+		$link_header = $headers['Link'] ?? '';
+
+		// Parse Link header for rel="next" and rel="prev"
+		$this->assertStringContainsString( 'rel="next"', $link_header );
+		$this->assertStringNotContainsString( 'rel="prev"', $link_header );
 
-		// Test middle page (should have both 'next' and 'prev' links)
+		// Test middle page (should have both 'next' and 'prev' link headers)
 		$request->set_param( 'page', 3 );
 		$response = $this->server->dispatch( $request );
 
-		$links = $response->get_links();
-		$this->assertArrayHasKey( 'next', $links );
-		$this->assertArrayHasKey( 'prev', $links );
+		$headers = $response->get_headers();
+		$link_header = $headers['Link'] ?? '';
 
-		// Test last page (should have 'prev' link but no 'next')
+		$this->assertStringContainsString( 'rel="next"', $link_header );
+		$this->assertStringContainsString( 'rel="prev"', $link_header );
+
+		// Test last page (should have 'prev' link header but no 'next')
 		$total_abilities = count( wp_get_abilities() );
 		$last_page       = ceil( $total_abilities / 10 );
 		$request->set_param( 'page', $last_page );
 		$response = $this->server->dispatch( $request );
 
-		$links = $response->get_links();
-		$this->assertArrayNotHasKey( 'next', $links );
-		$this->assertArrayHasKey( 'prev', $links );
+		$headers = $response->get_headers();
+		$link_header = $headers['Link'] ?? '';
+
+		$this->assertStringNotContainsString( 'rel="next"', $link_header );
+		$this->assertStringContainsString( 'rel="prev"', $link_header );
 	}
 
 	/**