Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the Post Content block be editable? #25394

Closed
ntsekouras opened this issue Sep 17, 2020 · 6 comments
Closed

Should the Post Content block be editable? #25394

ntsekouras opened this issue Sep 17, 2020 · 6 comments
Labels
[Block] Post Content Affects the Post Content Block [Type] Discussion For issues that are high-level and not yet ready to implement.

Comments

@ntsekouras
Copy link
Contributor

ntsekouras commented Sep 17, 2020

Currently the Post Content block when inserted is editable and a user can edit the content and save the changes to the respective post. This feels a bit weird and might confuse a user about what flows should follow.

While it can be convenient for some to use this, it might be better to have the post content locked and have a single clear flow on where to edit a post's content.

Related to the ongoing work on FSE the Milestone:5 about Query block. #24762.

@ntsekouras ntsekouras added [Block] Post Content Affects the Post Content Block [Type] Discussion For issues that are high-level and not yet ready to implement. labels Sep 17, 2020
@ntsekouras ntsekouras changed the title Should Post Content block be editable? Should the Post Content block be editable? Sep 17, 2020
@ntsekouras ntsekouras mentioned this issue Sep 17, 2020
8 tasks
@youknowriad
Copy link
Contributor

THe block itself should be editable (in FSE templates for instance) but maybe it can require a two steps edition (select, click edit...) in the context of the "Query" block. This needs some design thoughts.

@youknowriad youknowriad added the Needs Design Needs design efforts. label Sep 17, 2020
@mtias
Copy link
Member

mtias commented Sep 25, 2020

Let's start by locking editing. I'd like to get FSE into a state where display is working well before opening up edit of content too much.

@karmatosed
Copy link
Member

For now, I am going to remove 'needs design' as if it's going to not have the 2 steps I think that makes sense to remove. It can be added back in.

@karmatosed karmatosed removed the Needs Design Needs design efforts. label Nov 20, 2020
@bobbingwide
Copy link
Contributor

No. In my opinion the Post content should not be directly editable.
The block editor is confusing enough already. It's very difficult to understand the context.
There's hardly any visual feedback with regards to block nesting.
In order to know where a block is in the inner block hierarchy you have to use

  • the Outline toolicon and/or
  • the block icon's parent block and/or
  • the breadcrumbs links - which aren't in my field of view most of the time.

For an example of how things can go wrong see bobbingwide/fizzie#43 (comment)

@annezazu
Copy link
Contributor

Noting that the same "click to edit" flow might be useful to consider here #29337

@ntsekouras
Copy link
Contributor Author

Closing in favor of #32317 which explores the flow for 'locking' the Post blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Content Affects the Post Content Block [Type] Discussion For issues that are high-level and not yet ready to implement.
Projects
None yet
Development

No branches or pull requests

6 participants