Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all files have CODEOWNERS #1207

Closed
dhruvkb opened this issue Apr 14, 2023 · 1 comment
Closed

Ensure all files have CODEOWNERS #1207

dhruvkb opened this issue Apr 14, 2023 · 1 comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: mgmt Related to repo management and automations

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Apr 14, 2023

Problem

Considering how the monorepo is a complex mix of projects, languages and stacks, we cannot pick from the pool of all maintainers to review PRs. Hence the CODEOWNERS file is a complex Venn diagram of teams related to each part of the codebase.

In this complexity, it is easy for files and directories to be left with no owner at all.

Description

https://github.com/beaugunderson/codeowners is a tool to interact with the CODEOWNERS file. It can be used to find files that have no owner. Running it as a script in pre-commit can fix this issue.

Integrating it with pre-commit can help prevent these situations from being committed at all, but that is blocked on upstream issue beaugunderson/codeowners#36 to be resolved.
@dhruvkb dhruvkb added good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations labels Apr 14, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Apr 14, 2023
@AetherUnbound AetherUnbound mentioned this issue May 8, 2023
Closed
8 tasks
@dhruvkb
Copy link
Member Author

dhruvkb commented Dec 22, 2023

Closing as a duplicate of #3554 which has a better solution and a contributor working on it.

@dhruvkb dhruvkb closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2023
@openverse-bot openverse-bot moved this from 📋 Backlog to 🗑 Discarded in Openverse Backlog Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: mgmt Related to repo management and automations
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhruvkb