Props are not updated when commenting on a PR submitted from a forked repository

[t-hamano]

Description

Commenting on a PR submitted from a forked repository doesn't seem to update the props.

Here is that PR, with GitHub Actions being skipped.

WordPress/gutenberg#58662 (comment)

On the other hand, if a member of the repository comments on a PR submitted, the props seem to update correctly.

WordPress/gutenberg#58666 (comment)

My GitHub username is t-hamano and my .org username is wildworks. My GitHub and .org accounts are connected, and I've also added an alias for my email address on GitHub.

In such a case, should I manually add Co-authored-by when merging to trunk?

Version

@trunk

Workflow file

No response

Link

No response

[desrosj]

Interesting! Thanks for reporting @t-hamano!

This seems to be an issue with the pull_request_review/pull_request_review_comment triggers only.

To test I:

• Re-ran the bot using the props-bot label. The comment was successfully updated.
• Re-ran the workflow run attached th the PR that runs on pull_request_target. The comment was successfully updates.
• Commented on the issue. The comment was successfully updated.
• Created a new review (which also creates a new review comment). The comment update was unsuccessful.

It seems that all pull request related events (not just pull_request) are limited to what they are capable of for security reasons. The best course of action may be to avoid running the bot in this situation and encourage contributors to always use the label prior to merging.

For the time being, adding the props-bot label is the best way to refresh the list to ensure it is accurate.

[t-hamano]

I see, thank you!