Bootstrap for PDO API implementation (#297)

Extracting smaller chunks from
#291 so we
can review and merge them independently.

This PR renames the current `WP_SQLite_Driver` to
`WP_PDO_MySQL_On_SQLite` and reintroduces the `WP_SQLite_Driver` as a
simple proxy over the new renamed class. It's done in these two steps
(first rename, then reintroduce) so that Git understands the rename and
presents history (hopefully) accurately.

The changes are better understood in a commit-by-commit view.

#### `WP_PDO_MySQL_On_SQLite` vs `WP_SQLite_Driver`
The "reintroduced" `WP_SQLite_Driver` is not meant to be permanent. It
is a temporary proxy so we can gradually modify `WP_PDO_MySQL_On_SQLite`
to support PDO APIs while not touching the driver API just yet. Once the
basics of PDO API are in place, we can make all dependencies use the new
class directly and then remove the `WP_SQLite_Driver`.

That is, in the future, the `WP_SQLite_DB extends wpdb` will use
directly the new `WP_PDO_MySQL_On_SQLite` class.

Author: adamziel

packages/wp-mysql-proxy/src/Adapter/class-sqlite-adapter.php

@@ -9,24 +9,7 @@
 use WP_SQLite_Driver;
 use WP_MySQL_Proxy\MySQL_Protocol;
 
-define( 'SQLITE_DRIVER_PATH', __DIR__ . '/../../../..' );
-
-require_once SQLITE_DRIVER_PATH . '/version.php';
-require_once SQLITE_DRIVER_PATH . '/wp-includes/parser/class-wp-parser-grammar.php';
-require_once SQLITE_DRIVER_PATH . '/wp-includes/parser/class-wp-parser.php';
-require_once SQLITE_DRIVER_PATH . '/wp-includes/parser/class-wp-parser-node.php';
-require_once SQLITE_DRIVER_PATH . '/wp-includes/parser/class-wp-parser-token.php';
-require_once SQLITE_DRIVER_PATH . '/wp-includes/mysql/class-wp-mysql-token.php';
-require_once SQLITE_DRIVER_PATH . '/wp-includes/mysql/class-wp-mysql-lexer.php';
-require_once SQLITE_DRIVER_PATH . '/wp-includes/mysql/class-wp-mysql-parser.php';
-require_once SQLITE_DRIVER_PATH . '/wp-includes/sqlite/class-wp-sqlite-pdo-user-defined-functions.php';
-require_once SQLITE_DRIVER_PATH . '/wp-includes/sqlite-ast/class-wp-sqlite-connection.php';
-require_once SQLITE_DRIVER_PATH . '/wp-includes/sqlite-ast/class-wp-sqlite-configurator.php';
-require_once SQLITE_DRIVER_PATH . '/wp-includes/sqlite-ast/class-wp-sqlite-driver.php';
-require_once SQLITE_DRIVER_PATH . '/wp-includes/sqlite-ast/class-wp-sqlite-driver-exception.php';
-require_once SQLITE_DRIVER_PATH . '/wp-includes/sqlite-ast/class-wp-sqlite-information-schema-builder.php';
-require_once SQLITE_DRIVER_PATH . '/wp-includes/sqlite-ast/class-wp-sqlite-information-schema-exception.php';
-require_once SQLITE_DRIVER_PATH . '/wp-includes/sqlite-ast/class-wp-sqlite-information-schema-reconstructor.php';
+require_once __DIR__ . '/../../../../wp-pdo-mysql-on-sqlite.php';
 
 class SQLite_Adapter implements Adapter {
 	/** @var WP_SQLite_Driver */

tests/WP_SQLite_Driver_PDO_API_Tests.php …WP_PDO_MySQL_On_SQLite_PDO_API_Tests.phptests/WP_SQLite_Driver_PDO_API_Tests.php renamed to tests/WP_PDO_MySQL_On_SQLite_PDO_API_Tests.php tests/WP_SQLite_Driver_PDO_API_Tests.php renamed to tests/WP_PDO_MySQL_On_SQLite_PDO_API_Tests.php

@@ -2,13 +2,13 @@
 
 use PHPUnit\Framework\TestCase;
 
-class WP_SQLite_Driver_PDO_API_Tests extends TestCase {
-	/** @var WP_SQLite_Driver */
+class WP_PDO_MySQL_On_SQLite_PDO_API_Tests extends TestCase {
+	/** @var WP_PDO_MySQL_On_SQLite */
 	private $driver;
 
 	public function setUp(): void {
 		$connection   = new WP_SQLite_Connection( array( 'path' => ':memory:' ) );
-		$this->driver = new WP_SQLite_Driver( $connection, 'wp' );
+		$this->driver = new WP_PDO_MySQL_On_SQLite( $connection, 'wp' );
 	}
 
 	public function test_begin_transaction(): void {

tests/WP_SQLite_Information_Schema_Reconstructor_Tests.php

@@ -49,7 +49,7 @@ public function setUp(): void {
 		);
 
 		$builder = new WP_SQLite_Information_Schema_Builder(
-			WP_SQLite_Driver::RESERVED_PREFIX,
+			WP_PDO_MySQL_On_SQLite::RESERVED_PREFIX,
 			$this->engine->get_connection()
 		);
 

tests/bootstrap.php

@@ -1,26 +1,12 @@
 <?php
 
 require_once __DIR__ . '/wp-sqlite-schema.php';
-require_once __DIR__ . '/../version.php';
-require_once __DIR__ . '/../wp-includes/parser/class-wp-parser-grammar.php';
-require_once __DIR__ . '/../wp-includes/parser/class-wp-parser.php';
-require_once __DIR__ . '/../wp-includes/parser/class-wp-parser-node.php';
-require_once __DIR__ . '/../wp-includes/parser/class-wp-parser-token.php';
-require_once __DIR__ . '/../wp-includes/mysql/class-wp-mysql-token.php';
-require_once __DIR__ . '/../wp-includes/mysql/class-wp-mysql-lexer.php';
-require_once __DIR__ . '/../wp-includes/mysql/class-wp-mysql-parser.php';
+require_once __DIR__ . '/../wp-pdo-mysql-on-sqlite.php';
 require_once __DIR__ . '/../wp-includes/sqlite/class-wp-sqlite-query-rewriter.php';
 require_once __DIR__ . '/../wp-includes/sqlite/class-wp-sqlite-lexer.php';
 require_once __DIR__ . '/../wp-includes/sqlite/class-wp-sqlite-token.php';
 require_once __DIR__ . '/../wp-includes/sqlite/class-wp-sqlite-pdo-user-defined-functions.php';
 require_once __DIR__ . '/../wp-includes/sqlite/class-wp-sqlite-translator.php';
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-connection.php';
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-configurator.php';
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-driver.php';
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-driver-exception.php';
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-information-schema-builder.php';
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-information-schema-exception.php';
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-information-schema-reconstructor.php';
 
 // Configure the test environment.
 error_reporting( E_ALL );

tests/tools/dump-sqlite-query.php

@@ -1,20 +1,6 @@
 <?php
 
-require_once __DIR__ . '/../../wp-includes/parser/class-wp-parser.php';
-require_once __DIR__ . '/../../wp-includes/parser/class-wp-parser-grammar.php';
-require_once __DIR__ . '/../../wp-includes/parser/class-wp-parser-node.php';
-require_once __DIR__ . '/../../wp-includes/parser/class-wp-parser-token.php';
-require_once __DIR__ . '/../../wp-includes/mysql/class-wp-mysql-lexer.php';
-require_once __DIR__ . '/../../wp-includes/mysql/class-wp-mysql-token.php';
-require_once __DIR__ . '/../../wp-includes/mysql/class-wp-mysql-parser.php';
-require_once __DIR__ . '/../../wp-includes/sqlite/class-wp-sqlite-pdo-user-defined-functions.php';
-require_once __DIR__ . '/../../wp-includes/sqlite-ast/class-wp-sqlite-connection.php';
-require_once __DIR__ . '/../../wp-includes/sqlite-ast/class-wp-sqlite-configurator.php';
-require_once __DIR__ . '/../../wp-includes/sqlite-ast/class-wp-sqlite-driver.php';
-require_once __DIR__ . '/../../wp-includes/sqlite-ast/class-wp-sqlite-driver-exception.php';
-require_once __DIR__ . '/../../wp-includes/sqlite-ast/class-wp-sqlite-information-schema-builder.php';
-require_once __DIR__ . '/../../wp-includes/sqlite-ast/class-wp-sqlite-information-schema-exception.php';
-require_once __DIR__ . '/../../wp-includes/sqlite-ast/class-wp-sqlite-information-schema-reconstructor.php';
+require_once __DIR__ . '/../../wp-pdo-mysql-on-sqlite.php';
 
 $driver = new WP_SQLite_Driver(
 	new WP_SQLite_Connection( array( 'path' => ':memory:' ) ),