Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The core Language Switcher should not be present on the Two factor authentication screen #520

Closed
dd32 opened this issue Feb 14, 2023 · 1 comment · Fixed by #521
Closed
Milestone

Comments

@dd32
Copy link
Member

dd32 commented Feb 14, 2023

The core Language switcher is present on the Two Factor prompt screen, it really doesn't need to be there, and adds noise to the login UI.

It also cancels the 2FA login and throws the user back to the start of the login flow.

Screenshot 2023-02-14 at 4 04 02 pm

@dd32 dd32 added the Bug label Feb 14, 2023
dd32 added a commit to dd32/two-factor that referenced this issue Feb 14, 2023
@jeffpaul jeffpaul added this to the 0.8.0 milestone Feb 15, 2023
@iandunn iandunn modified the milestones: 0.8.0, 0.9.0 Mar 6, 2023
dd32 added a commit to dd32/two-factor that referenced this issue Apr 13, 2023
dd32 added a commit that referenced this issue Apr 28, 2023
* Replace strings with more user-friendly wordings.

* Hide the Language dropdown when we're on a 2FA page. See #520

* Try an alternative simpler login UI for the 'Or continue with...' buttons.

* Try using a GitHub-style 'Having Problems?' + list style.

* Rename backup codes to 'Recovery Codes', to dissuade their regular use.
@dd32
Copy link
Member Author

dd32 commented Apr 28, 2023

Resolved via #521

@dd32 dd32 closed this as completed Apr 28, 2023
@jeffpaul jeffpaul linked a pull request May 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants