Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground Fatal error when activating a plugin via github release #2126

Open
aaronjbaptiste opened this issue Jan 13, 2025 · 0 comments
Open

Comments

@aaronjbaptiste
Copy link

aaronjbaptiste commented Jan 13, 2025

I believe #2066 has caused a regression when activating a plugin via github release.

Image

To reproduce:

git checkout 406811fd9b5442340ec5cd0c732ce270a199b922
npm install 
npm run dev

Then go to:

http://127.0.0.1:5400/website-server/#{%22landingPage%22:%22/wp-admin/%22,%22features%22:{%22networking%22:true},%22preferredVersions%22:{%22wp%22:%22latest%22,%22php%22:%228.3%22},%22login%22:true,%22steps%22:[{%22step%22:%22installPlugin%22,%22pluginData%22:{%22resource%22:%22url%22,%22url%22:%22https://github-proxy.com/proxy/?repo=ryanwelcher/interactivity-api-todomvc&release=v0.1.3&asset=to-do-mvc.zip%22},%22options%22:{%22activate%22:true}}]}

This version, which does not activate via release zip, is working fine: http://127.0.0.1:5400/website-server/#{%22landingPage%22:%22/wp-admin/%22,%22features%22:{%22networking%22:true},%22preferredVersions%22:{%22wp%22:%22latest%22,%22php%22:%228.3%22},%22login%22:true,%22steps%22:[{%22step%22:%22installPlugin%22,%22pluginData%22:{%22resource%22:%22url%22,%22url%22:%22https://github-proxy.com/proxy/?repo=ryanwelcher/interactivity-api-todomvc%22},%22options%22:{%22activate%22:true}}]}

Also reproduced with: http://127.0.0.1:5400/website-server/?blueprint-url=https://raw.githubusercontent.com/Automattic/tumblr-theme-garden/refs/heads/trunk/blueprint.json which uses a release zip.

This changeset, the one before #2066 is working:

git checkout 406811fd9b5442340ec5cd0c732ce270a199b922^
npm install 
npm run dev

(check the same urls above)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Inbox
Development

No branches or pull requests

1 participant