Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Backup Codes Management #40

Closed
iandunn opened this issue Jan 11, 2023 · 1 comment
Closed

UI: Backup Codes Management #40

iandunn opened this issue Jan 11, 2023 · 1 comment
Assignees
Milestone

Comments

@iandunn
Copy link
Member

iandunn commented Jan 11, 2023

After the setup process is done in #39 , we should add a way to regenerate the codes.

See #18 for mockups, may also need to look at WordPress.com for some of the interactions that aren't covered in the screenshots.

WordPress/two-factor#504 will need to be used locally until it's merged, so that we can use the REST API to interact with the upstream plugin.

This could potentially be done in two PRs, ala Thinking in React: one to stub out the UI, and then a second to add dynamic functionality.

@iandunn iandunn added this to the MVP milestone Jan 11, 2023
@iandunn
Copy link
Member Author

iandunn commented Jan 25, 2023

I don't think we need to verify backup codes like the WPCOM design does. It's not like TOTP, where the setup process is complex and we need to make sure it worked, because if we don't the user will be locked out of their account. Backup codes are much simpler.

Verifying after they've been enabled also uses up a code, which might later confuse a user when it doesn't work.

If a compelling reason presents itself, we can always add that later.

@iandunn iandunn self-assigned this Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant