Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config file for generator parser #9

Open
WorldofKerry opened this issue Jul 11, 2023 · 2 comments
Open

Add config file for generator parser #9

WorldofKerry opened this issue Jul 11, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@WorldofKerry
Copy link
Owner

WorldofKerry commented Jul 11, 2023

Quite a few assumed conventions should be configurable:

  1. Name of the standard I/O, e.g. start, valid, done ready, etc.
    Including the ability to configure them as active high or active low
  2. How the states (in the state machine) are named should also be configurable, e.g. the _state prefix

.ini files are currently used for the test cases. They could be used for this too, but moving to .toml may also be a good idea.

Could be implemented by passing an optional (file in the case of CLI, or dict in the case of package API), which can then be parsed and used to initialize the base Context class. Perhaps in the case of the package API, the context class could be passed instead?

Not too high priority, as if the user must, they can change the source code, primarily the defaults of the Context class.

@WorldofKerry WorldofKerry added the enhancement New feature or request label Jul 11, 2023
@WorldofKerry WorldofKerry added the good first issue Good for newcomers label Jul 18, 2023
@WorldofKerry
Copy link
Owner Author

WorldofKerry commented Aug 16, 2023

Lacks purpose, now that Context class added in #73 contains default signal names.

@Haxrox
Copy link
Collaborator

Haxrox commented Sep 12, 2023

What is the purpose of allowing users to change the standard I/O signal names? Similarly with the states naming convention

I like the idea of allowing users to select active high or active low

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants