chg: remove redundant isinstance() check

lindsay-stevens · lindsay-stevens · commit dddb5635b4e8 · 2025-12-10T23:12:06.000+11:00
- L791 does a str() conversion so question_name can never be bytes
diff --git a/pyxform/xls2json.py b/pyxform/xls2json.py
@@ -790,9 +790,6 @@ def workbook_to_json(
                 )
         question_name = str(row[constants.NAME])
         if not is_xml_tag(question_name):
-            if isinstance(question_name, bytes):
-                question_name = question_name.decode("utf-8")
-
             raise PyXFormError(
                 f"{ROW_FORMAT_STRING % row_number} Invalid question name '{question_name}'. Names {XML_IDENTIFIER_ERROR_MESSAGE}"
             )

Original file line number	Diff line number	Diff line change
`@@ -790,9 +790,6 @@ def workbook_to_json(`
`790`	`790`	`)`
`791`	`791`	`question_name = str(row[constants.NAME])`
`792`	`792`	`if not is_xml_tag(question_name):`
`793`		`- if isinstance(question_name, bytes):`
`794`		`- question_name = question_name.decode("utf-8")`
`795`		`-`
`796`	`793`	`raise PyXFormError(`
`797`	`794`	`f"{ROW_FORMAT_STRING % row_number} Invalid question name '{question_name}'. Names {XML_IDENTIFIER_ERROR_MESSAGE}"`
`798`	`795`	`)`