Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async factory methods to health check DI methods. #2306

Open
mitchdenny opened this issue Oct 14, 2024 · 0 comments
Open

Add async factory methods to health check DI methods. #2306

mitchdenny opened this issue Oct 14, 2024 · 0 comments

Comments

@mitchdenny
Copy link

What would you like to be added:

Factory methods on checks should allow for async callbacks. I've created a PR with some context:

#2305

Why is this needed:

We are using these libraries in .NET Aspire and connection string information for health checks that are running in the AppHost are not available until after the container is built, and to acquire the connection string we need to make an async call. We are working around it at the moment, but we desire to simplify our code somewhat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant