Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of ConnectionString Support in HealthChecks.AzureApplicationInsights #2313

Open
shayne-marriage-scp opened this issue Nov 7, 2024 · 0 comments

Comments

@shayne-marriage-scp
Copy link

Issue: Lack of ConnectionString Support in HealthChecks.AzureApplicationInsights

Description

The HealthChecks.AzureApplicationInsights package currently supports only the InstrumentationKey for connecting to Azure Application Insights. However, Microsoft is deprecating the InstrumentationKey and recommends using the ConnectionString instead. Support for InstrumentationKey ends on March 31, 2025. To future-proof this package and ensure compatibility with Application Insights, it needs to add support for ConnectionString.

Expected Behavior

The package should allow users to specify a ConnectionString as an alternative to the InstrumentationKey for connecting to Azure Application Insights. InstrumentationKey property is marked Obsolete. This will align with Microsoft's guidance and deprecation plans /ApplicationInsights-dotnet/issues/2560.

Current Behavior

Currently, the package only accepts InstrumentationKey, which will soon become obsolete, potentially breaking integrations or requiring manual updates to align with Azure's requirements.

Suggested Solution

  1. Add a ConnectionString parameter: Update the health check configuration to accept a ConnectionString for Azure Application Insights.
  2. Deprecate the InstrumentationKey: Mark InstrumentationKey as deprecated, but keep it for backward compatibility until it’s removed entirely by Microsoft.
  3. Documentation: Update the README and any other relevant documentation to reflect this change, providing usage examples with the ConnectionString.
@shayne-marriage-scp shayne-marriage-scp changed the title Lack of ConnectionString Support in Xabril.HealthChecks.AzureApplicationInsights Lack of ConnectionString Support in HealthChecks.AzureApplicationInsights Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant