Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

APIException with If-Modified-Since too small #16

Open
meboz opened this issue Feb 23, 2012 · 0 comments
Open

APIException with If-Modified-Since too small #16

meboz opened this issue Feb 23, 2012 · 0 comments

Comments

@meboz
Copy link
Contributor

meboz commented Feb 23, 2012

relates to this discussion, but Ill raise it here then add some validation in the wrapper.

https://community.xero.com/developer/discussion/56611/

If you supply an If-Modified-Since header that is smaller than 01/01/1753 (the min value for a SqlDateTime), the API call executes but returns 500.

For users of the wrapper library, we could validate this client side and provide some useful exception and msg before the call hits the server.

Validation should probably still occur server side as it took me some time to debug why the server threw a 500.

Ill provide a test and a patch and submit a pull request.

Cheers,
Byron

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant