Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test tcp_rmem and tcp_wmem max values handling #102

Open
okt-sergeyn opened this issue Jul 29, 2024 · 0 comments
Open

Test tcp_rmem and tcp_wmem max values handling #102

okt-sergeyn opened this issue Jul 29, 2024 · 0 comments

Comments

@okt-sergeyn
Copy link
Contributor

Inspired by Xilinx-CNS/onload#227

In sockapi-ts/sockopts/max_bufs.c (https://github.com/Xilinx-CNS/cns-sapi-ts/blob/main/sockapi-ts/sockopts/max_bufs.c#L205)
it is written:

    /*
     * Note: for TCP tcp_wmem and tcp_rmem should not be taken into
     * account here; they are used for dymanic TCP buffers adjustment
     * and do not limit SO_SNDBUF/SO_RCVBUF according to Linux manual.
     */

However, the test doesn't check that.
I suggest to extend tcp iterations of the test (or create another one, idk) and check that tcp_wmem[2] and tcp_rmem[2] do not limit SO_SNDBUF/SO_RCVBUF socket options.

See man 7 tcp

       tcp_rmem (since Linux 2.4)
...
              max    the  maximum size of the receive buffer used by each TCP socket.  This value does
                     not override the global net.core.rmem_max.  This is not used to limit the size of
                     the  receive  buffer  declared using SO_RCVBUF on a socket.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant