Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'voting' type of clustering for Enterprise Profile #4

Open
abower-amd opened this issue Oct 27, 2023 · 0 comments
Open

Add 'voting' type of clustering for Enterprise Profile #4

abower-amd opened this issue Oct 27, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@abower-amd
Copy link
Collaborator

The clustering feature which gives a score to remote clock sources based on their time offsets currently has one implementation, the 'discriminator' mode. The 'discriminator' mode filters out sources which are significantly off from a source which is trusted to provide a good time, even if it is not provided to a very high accuracy, e.g. NTP.

Where there are three or more high quality (e.g. PTP or PPS) sources available then a preferable form of clustering may be a 'voting' algorithm allowing the sources which diverge significantly from the majority of sources to be filtered out.

The task here is to add a 'voting' type of clustering which can be configured to this end. As with the discriminator, which is binary, there is likely to be some quantization needed in this determination so that the other selection criteria continue to be used effectively.

Implementation of this feature would improve the 'Enterprise Profile' offering in sfptpd.

The clustering calculation is currently performed on behalf of the sync instances by a callback in sfptpd_engine.c and defined in the global configuration sfptpd_general_config.c. It is possible that a future change will simplify these mechanics to avoid the callback and determine the score solely in the engine but this should not affect the implementation of this proposed enhancement.

@abower-amd abower-amd added the enhancement New feature or request label Oct 27, 2023
@abower-amd abower-amd changed the title Add new 'voting' type of clustering Add 'voting' type of clustering for Enterprise Profile Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant