Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default template don't allow template overwriting #13

Open
slider84 opened this issue Aug 31, 2015 · 8 comments
Open

Default template don't allow template overwriting #13

slider84 opened this issue Aug 31, 2015 · 8 comments

Comments

@slider84
Copy link

Old buttons from default template still in place when using template overwriting.
newbb

@mambax7
Copy link
Contributor

mambax7 commented Aug 31, 2015

How should it look like? How and where did you overwrite the templates?

@slider84
Copy link
Author

It should look like this:
oldnewbb
I'm making a new fast bootstrap theme with minimal css files.
It's easy to reproduce with xbootstrap theme. Just rename (or delete) the css directory under /themes/xbootstrap/modules/newbb/directory (no need for my new theme). Then old buttons appears over the template overwrite.

@slider84
Copy link
Author

ie: Look at the IP adress (old IP in the DB) in the screenshot after update from your RC10 version.
in the db old IP are formated like 127.0.0.1, new IP looks like 2130706433

@mambax7
Copy link
Contributor

mambax7 commented Aug 31, 2015

Reg. the IP, you need to make sure that you have the original DB, where the fields were stored as "long IP", i.e. they were converted to a number using ip2long() function, and they should look like:
3496366814
With the current upgrade, it should convert to:
208.102.82.222
At least that's what we have in our XOOPS database.
If you have currently "127.0.0.1" in your DB, then it's possible that you ran already the upgrade, and therefore you will not get the correct results.
Please also start a new issue as it relates to the IP, so we can keep it separate from the CSS/Theme issue.

@mambax7
Copy link
Contributor

mambax7 commented Aug 31, 2015

Reg. the templates, you can talk to Bleekk, who is working on a new templates as well:
http://myxoops.xoopsthemes.com/modules/newbb/

@cesagonchu
Copy link

I asked Bleekk, but he doesn't give any news and has not responded to my last private message...

@myxoops
Copy link

myxoops commented Sep 23, 2015

Hi,

I am really sorry but I didn't have time to look for this problem.

The style of these buttons is created in /class/icon.php in the function assignImage.
Find this line: $extra = "class='forum_icon forum_button'";
Here you can change the css classes that you want to have, like "btn btn-primary"

I have changed the line to this: $extra = "class='btn btn-primary'";

This function should be completely removed and designer should be able to change the style of the buttons in the templates

Best regards
Bleekk

@cesagonchu
Copy link

Thanks for your answer.

mambax7 added a commit to mambax7/newbb that referenced this issue Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants