remove unneeded GetHashCode in THashResult

Author: Xor-el

HashLib/src/Base/HlpHashResult.pas

@@ -6,16 +6,6 @@ interface
 
 uses
   SysUtils,
-{$IFDEF FPC}
-  base64,
-{$ELSE}
-{$IFDEF HAS_DELPHI_NET_ENCODING}
-  System.NetEncoding,
-{$ELSE}
-  Classes,
-  EncdDecd,
-{$ENDIF HAS_DELPHI_NET_ENCODING}
-{$ENDIF FPC}
   HlpBits,
   HlpHashLibTypes,
   HlpIHashResult,
@@ -49,8 +39,6 @@   THashResult = class sealed(TInterfacedObject, IHashResult)
     function GetUInt64(): UInt64;
     function ToString(AGroup: Boolean = False): String; reintroduce;
     function Equals(const AHashResult: IHashResult): Boolean; reintroduce;
-    function GetHashCode(): {$IFDEF DELPHI}Int32; {$ELSE}PtrInt;
-{$ENDIF DELPHI}override;
 
   end;
 
@@ -107,68 +95,6 @@ function THashResult.GetBytes: THashLibByteArray;
   result := FHash;
 end;
 
-function THashResult.GetHashCode: {$IFDEF DELPHI}Int32; {$ELSE}PtrInt;
-{$ENDIF DELPHI}
-
-var
-  LResult: UInt32;
-  LIdx, LTop: Int32;
-  LTemp: String;
-{$IFDEF HAS_DELPHI_NET_ENCODING}
-  LTempHolder: THashLibByteArray;
-{$ELSE}
-{$IFDEF DELPHI}
-  LTempHolder: TBytesStream;
-{$ENDIF DELPHI}
-{$ENDIF HAS_DELPHI_NET_ENCODING}
-{$IFDEF FPC}
-  LTempHolder: String;
-{$ENDIF FPC}
-begin
-
-{$IFDEF HAS_DELPHI_NET_ENCODING}
-  LTempHolder := Self.FHash;
-{$ELSE}
-{$IFDEF DELPHI}
-  LTempHolder := TBytesStream.Create(Self.FHash);
-{$ENDIF DELPHI}
-{$ENDIF HAS_DELPHI_NET_ENCODING}
-{$IFDEF FPC}
-  LTempHolder := EncodeStringBase64(TConverters.ConvertBytesToString(Self.FHash,
-    TEncoding.UTF8));
-{$ENDIF FPC}
-{$IFDEF HAS_DELPHI_NET_ENCODING}
-  LTemp := StringReplace(TNetEncoding.base64.EncodeBytesToString(LTempHolder),
-    sLineBreak, '', [rfReplaceAll]);
-{$ELSE}
-{$IFDEF DELPHI}
-  try
-    LTemp := StringReplace(String(EncodeBase64(LTempHolder.Memory,
-      LTempHolder.Size)), sLineBreak, '', [rfReplaceAll]);
-  finally
-    LTempHolder.Free;
-  end;
-{$ENDIF DELPHI}
-{$ENDIF HAS_DELPHI_NET_ENCODING}
-{$IFDEF FPC}
-  LTemp := LTempHolder;
-{$ENDIF FPC}
-  LTemp := AnsiUpperCase(LTemp);
-
-  LResult := 0;
-  LIdx := 1;
-  LTop := System.Length(LTemp);
-
-  while LIdx <= LTop do
-  begin
-    LResult := TBits.RotateLeft32(LResult, 5);
-    LResult := LResult xor UInt32(LTemp[LIdx]);
-    System.Inc(LIdx);
-  end;
-
-  result := LResult;
-end;
-
 function THashResult.GetInt32: Int32;
 begin
   if System.Length(FHash) <> sizeof(Int32) then

HashLib/src/Interfaces/HlpIHashResult.pas

@@ -19,8 +19,6 @@ interface
     function GetUInt64(): UInt64;
     function ToString(AGroup: Boolean = False): String;
     function Equals(const AHashResult: IHashResult): Boolean; overload;
-    function GetHashCode(): {$IFDEF DELPHI}Int32; {$ELSE}PtrInt;
-{$ENDIF DELPHI}
   end;
 
 implementation

HashLib/src/Packages/Delphi/HashLib4PascalPackage.dpk

@@ -32,8 +32,7 @@ package HashLib4PascalPackage;
 {$IMPLICITBUILD ON}
 
 requires
-  rtl,
-  soaprtl;
+  rtl;
 
 contains
   HlpHash in '..\..\Base\HlpHash.pas',