You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would it be possible to add support for cancelling tasks, main method that needs this is NextTweetStreamAsync because as of now it is not possible to stop stream execution. This causes multiple problems:
NextTweetStreamAsync is effectively blocking call, cannot be stopped in any way
Implementation of handler function is effectively locked and can be changed only in very stupid ways
Off the top of my head there are two solutions to this situation
Exposing streams with tweets to users
Adding support for CancellationToken (this ticket)
If you do not see any problems with this ticket I am willing to make PR to fix this problem.
I thank for your response in advance 🙏🏼
The text was updated successfully, but these errors were encountered:
Well in my opinion this are 2 totally different things, CancelTweetStream should in my opinion be used when you are closing stream willingly. Addition of logic for cancellation token would allow closure for failing tasks from outside without need to run NextTweetStreamAsync in the background.
I was a bit upfront and already implemented "changes in logic" along with small refactor in this PR 💪🏼 😊
Would it be possible to add support for cancelling tasks, main method that needs this is NextTweetStreamAsync because as of now it is not possible to stop stream execution. This causes multiple problems:
Off the top of my head there are two solutions to this situation
If you do not see any problems with this ticket I am willing to make PR to fix this problem.
I thank for your response in advance 🙏🏼
The text was updated successfully, but these errors were encountered: