fix: resolve CI issues and apply CodeRabbit suggestions

- Fixed all Rust Clippy warnings:
  - Added Default impl for AppLogger
  - Reduced function arguments using structs for log_file_progress and log_translation_completion
  - Replaced match with if-let for single pattern matching
  - Used .first() instead of .get(0)
  - Fixed map_or with is_some_and
  - Fixed unused variables and imports
  - Fixed deprecated warning with #[allow(deprecated)]

- Applied CodeRabbit suggestions:
  - Extracted lang file parsing logic to a reusable utility module
  - Created parseLangFile and stringifyLangFile functions
  - Updated quests-tab.tsx to use the new utility

Co-Authored-By: Claude <[email protected]>

Author: Y-RyuZU

src-tauri/src/filesystem.rs

@@ -82,7 +82,7 @@ pub async fn get_mod_files(
         let entry_path = entry.path();
 
         // Check if the file is a JAR file
-        if entry_path.is_file() && entry_path.extension().map_or(false, |ext| ext == "jar") {
+        if entry_path.is_file() && entry_path.extension().is_some_and(|ext| ext == "jar") {
             if let Some(path_str) = entry_path.to_str() {
                 mod_files.push(path_str.to_string());
             }
@@ -139,7 +139,7 @@ pub async fn get_ftb_quest_files(
 
                         // Check if the file is a JSON file and not already translated
                         if entry_path.is_file()
-                            && entry_path.extension().map_or(false, |ext| ext == "json")
+                            && entry_path.extension().is_some_and(|ext| ext == "json")
                         {
                             // Skip files that already have language suffixes
                             if let Some(file_name) = entry_path.file_name().and_then(|n| n.to_str())
@@ -211,7 +211,7 @@ pub async fn get_ftb_quest_files(
 
                             // Check if the file is an SNBT file and not already translated
                             if entry_path.is_file()
-                                && entry_path.extension().map_or(false, |ext| ext == "snbt")
+                                && entry_path.extension().is_some_and(|ext| ext == "snbt")
                             {
                                 // Skip files that already have language suffixes (e.g., filename.ja_jp.snbt)
                                 if let Some(file_name) =
@@ -259,7 +259,7 @@ pub async fn get_ftb_quest_files(
 
         if !quest_dir_found {
             info!("No FTB quests directory found in standard locations");
-            return Err(format!("No FTB quests directory found. Checked: config/ftbquests/quests/, config/ftbquests/normal/, and config/ftbquests/"));
+            return Err("No FTB quests directory found. Checked: config/ftbquests/quests/, config/ftbquests/normal/, and config/ftbquests/".to_string());
         }
     }
 
@@ -304,7 +304,7 @@ pub async fn get_better_quest_files(
             let entry_path = entry.path();
 
             // Check if the file is a JSON file and not already translated
-            if entry_path.is_file() && entry_path.extension().map_or(false, |ext| ext == "json") {
+            if entry_path.is_file() && entry_path.extension().is_some_and(|ext| ext == "json") {
                 // Skip files that already have language suffixes
                 if let Some(file_name) = entry_path.file_name().and_then(|n| n.to_str()) {
                     if file_name.contains(".ja_jp.")
@@ -383,7 +383,7 @@ pub async fn get_files_with_extension(
 
         // Check if the file has the specified extension
         if entry_path.is_file()
-            && entry_path.extension().map_or(false, |ext| {
+            && entry_path.extension().is_some_and(|ext| {
                 ext.to_string_lossy() == extension.trim_start_matches('.')
             })
         {
@@ -507,7 +507,7 @@ pub async fn create_resource_pack(
     let dir_path = Path::new(dir);
     if !dir_path.exists() || !dir_path.is_dir() {
         // Try to create the parent directory if it does not exist
-        if let Err(e) = std::fs::create_dir_all(&dir_path) {
+        if let Err(e) = std::fs::create_dir_all(dir_path) {
             return Err(format!(
                 "Failed to create parent directory: {} ({})",
                 dir, e
@@ -650,6 +650,7 @@ pub async fn open_external_url(
 
     // Use Tauri's shell plugin to open the URL
     let shell = app_handle.shell();
+    #[allow(deprecated)]
     match shell.open(url, None) {
         Ok(_) => {
             info!("Successfully opened URL: {}", url);

src-tauri/src/logging.rs

@@ -6,7 +6,7 @@ use std::io::Write;
 use std::path::PathBuf;
 use std::sync::{Arc, Mutex};
 use tauri::AppHandle;
-use tauri::{Emitter, Manager};
+use tauri::Emitter;
 
 /// Maximum number of log entries to keep in memory
 const MAX_LOG_ENTRIES: usize = 1000;
@@ -55,6 +55,12 @@ pub struct AppLogger {
     log_file_path: Arc<Mutex<Option<PathBuf>>>,
 }
 
+impl Default for AppLogger {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl AppLogger {
     /// Create a new logger
     pub fn new() -> Self {
@@ -441,18 +447,33 @@ pub fn log_translation_statistics(
     }
 }
 
+/// Progress information for file translation
+#[derive(serde::Deserialize)]
+pub struct FileProgressInfo {
+    pub file_name: String,
+    pub file_index: i32,
+    pub total_files: i32,
+    pub chunks_completed: i32,
+    pub total_chunks: i32,
+    pub keys_completed: i32,
+    pub total_keys: i32,
+}
+
 /// Log individual file progress with detailed status
 #[tauri::command]
 pub fn log_file_progress(
-    file_name: &str,
-    file_index: i32,
-    total_files: i32,
-    chunks_completed: i32,
-    total_chunks: i32,
-    keys_completed: i32,
-    total_keys: i32,
+    info: FileProgressInfo,
     logger: tauri::State<Arc<AppLogger>>,
 ) {
+    let FileProgressInfo {
+        file_name,
+        file_index,
+        total_files,
+        chunks_completed,
+        total_chunks,
+        keys_completed,
+        total_keys,
+    } = info;
     let percentage = if total_files > 0 {
         (file_index as f32 / total_files as f32 * 100.0) as i32
     } else {
@@ -474,18 +495,33 @@ pub fn log_file_progress(
     logger.info(&message, Some("TRANSLATION_PROGRESS"));
 }
 
+/// Summary information for translation completion
+#[derive(serde::Deserialize)]
+pub struct TranslationCompletionInfo {
+    pub session_id: String,
+    pub duration_seconds: f64,
+    pub total_files_processed: i32,
+    pub successful_files: i32,
+    pub failed_files: i32,
+    pub total_keys_translated: i32,
+    pub total_api_calls: i32,
+}
+
 /// Log translation completion with comprehensive summary
 #[tauri::command]
 pub fn log_translation_completion(
-    session_id: &str,
-    duration_seconds: f64,
-    total_files_processed: i32,
-    successful_files: i32,
-    failed_files: i32,
-    total_keys_translated: i32,
-    total_api_calls: i32,
+    info: TranslationCompletionInfo,
     logger: tauri::State<Arc<AppLogger>>,
 ) {
+    let TranslationCompletionInfo {
+        session_id,
+        duration_seconds,
+        total_files_processed,
+        successful_files,
+        failed_files,
+        total_keys_translated,
+        total_api_calls,
+    } = info;
     let success_rate = if total_files_processed > 0 {
         (successful_files as f32 / total_files_processed as f32 * 100.0) as i32
     } else {

src-tauri/src/minecraft/mod.rs

@@ -483,7 +483,7 @@ fn extract_mod_info(archive: &mut ZipArchive<File>) -> Result<(String, String, S
             .collect();
 
         // Try to convert to UTF-8, handling invalid sequences
-        let content = String::from_utf8_lossy(&cleaned_buffer).to_string();
+        let _content = String::from_utf8_lossy(&cleaned_buffer).to_string();
 
         // Use a default mod ID
         let jar_name = "unknown".to_string();
@@ -717,15 +717,11 @@ fn strip_json_comments(json: &str) -> String {
 
     // If not valid, try to fix it
     // Try to parse as serde_json::Value to get more lenient parsing
-    match relaxed_json_parse(&cleaned_json) {
-        Ok(value) => {
-            // Successfully parsed with relaxed parser, serialize back to valid JSON
-            match serde_json::to_string(&value) {
-                Ok(fixed_json) => return fixed_json,
-                Err(_) => {} // Fall back to line-by-line processing
-            }
+    if let Ok(value) = relaxed_json_parse(&cleaned_json) {
+        // Successfully parsed with relaxed parser, serialize back to valid JSON
+        if let Ok(fixed_json) = serde_json::to_string(&value) {
+            return fixed_json;
         }
-        Err(_) => {} // Fall back to line-by-line processing
     }
 
     // If relaxed parsing failed, try line-by-line cleanup
@@ -828,7 +824,7 @@ fn extract_patchouli_books_from_archive(
     let mut patchouli_books = Vec::new();
 
     // Regex to find Patchouli book root directories
-    let patchouli_book_root_re = Regex::new(r"^assets/([^/]+)/patchouli_books/([^/]+)/").unwrap();
+    let _patchouli_book_root_re = Regex::new(r"^assets/([^/]+)/patchouli_books/([^/]+)/").unwrap();
     // Regex to match en_us/**/*.json files (サブディレクトリも含む)
     let en_us_json_re =
         Regex::new(r"^assets/([^/]+)/patchouli_books/([^/]+)/en_us/(.+\.json)$").unwrap();
@@ -847,7 +843,7 @@ fn extract_patchouli_books_from_archive(
         if let Some(caps) = en_us_json_re.captures(&name) {
             let book_mod_id = caps.get(1).unwrap().as_str().to_string();
             let book_id = caps.get(2).unwrap().as_str().to_string();
-            let json_rel_path = caps.get(3).unwrap().as_str().to_string();
+            let _json_rel_path = caps.get(3).unwrap().as_str().to_string();
 
             // Read file content as string
             let mut buffer = Vec::new();
@@ -910,7 +906,7 @@ fn extract_patchouli_books_from_archive(
     for (_book_key, (book_mod_id, book_id, lang_files)) in books_map {
         // Use book_id as name for now (could be improved if needed)
         let path = lang_files
-            .get(0)
+            .first()
             .map(|lf| lf.path.clone())
             .unwrap_or_else(|| "".to_string());
 

src/components/tabs/quests-tab.tsx

@@ -7,6 +7,7 @@ import {TranslationService, TranslationJob} from "@/lib/services/translation-ser
 import {TranslationTab} from "@/components/tabs/common/translation-tab";
 import {invoke} from "@tauri-apps/api/core";
 import {runTranslationJobs} from "@/lib/services/translation-runner";
+import {parseLangFile} from "@/lib/utils/lang-parser";
 
 export function QuestsTab() {
     const {
@@ -150,21 +151,7 @@ export function QuestsTab() {
 
                     // If it's a .lang file, convert to JSON format for translation
                     if (target.path.endsWith('.lang')) {
-                        const langMap: Record<string, string> = {};
-                        const lines = content.split('\n');
-                        
-                        for (const line of lines) {
-                            const trimmed = line.trim();
-                            // Skip empty lines and comments
-                            if (trimmed && !trimmed.startsWith('#')) {
-                                const separatorIndex = trimmed.indexOf('=');
-                                if (separatorIndex > -1) {
-                                    const key = trimmed.substring(0, separatorIndex).trim();
-                                    const value = trimmed.substring(separatorIndex + 1).trim();
-                                    langMap[key] = value;
-                                }
-                            }
-                        }
+                        const langMap = parseLangFile(content);
 
                         // Convert to JSON string for translation
                         processedContent = JSON.stringify(langMap, null, 2);

src/lib/utils/lang-parser.ts

@@ -0,0 +1,37 @@
+/**
+ * Parse a .lang file content into a key-value map
+ * @param content The content of the .lang file
+ * @returns A map of key-value pairs
+ */
+export function parseLangFile(content: string): Record<string, string> {
+  const langMap: Record<string, string> = {};
+  const lines = content.split('\n');
+  
+  for (const line of lines) {
+    const trimmed = line.trim();
+    // Skip empty lines and comments
+    if (trimmed && !trimmed.startsWith('#')) {
+      const separatorIndex = trimmed.indexOf('=');
+      if (separatorIndex > -1) {
+        const key = trimmed.substring(0, separatorIndex).trim();
+        const value = trimmed.substring(separatorIndex + 1).trim();
+        if (key) {
+          langMap[key] = value;
+        }
+      }
+    }
+  }
+  
+  return langMap;
+}
+
+/**
+ * Convert a key-value map to .lang file format
+ * @param langMap The key-value map to convert
+ * @returns The .lang file content
+ */
+export function stringifyLangFile(langMap: Record<string, string>): string {
+  return Object.entries(langMap)
+    .map(([key, value]) => `${key}=${value}`)
+    .join('\n');
+}