Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename reconstruct_.json for each tile #4

Closed
Mboga opened this issue Apr 11, 2023 · 6 comments
Closed

Rename reconstruct_.json for each tile #4

Mboga opened this issue Apr 11, 2023 · 6 comments

Comments

@Mboga
Copy link

Mboga commented Apr 11, 2023

Thanks for the tool.

I am wondering in line 453 of reconstruct.json, if you should rename the reconstruct_.json for each of the new tile. This would happen after line 499 in main.py as data['nodes']['NestedFlowchart']['parameters'] = 'reconstruct{}_'.format(i) ?

Thank you

@Yarroudh
Copy link
Owner

Yarroudh commented Apr 11, 2023

Thank you for feedback @Mboga
I will look at your proposition soon to see what can be adjsuted or done.

@Yarroudh
Copy link
Owner

Yarroudh commented Apr 14, 2023

Apparently, when changing the filepath to reconstruct{i}_.json, the reconstruction fails completely as it cannot point to the right file.

These are the logs of the reconstruct file after adding:
data['nodes']['NestedFlowchart']['parameters'] = 'reconstruct{}_'.format(i)

logs.txt

@Yarroudh
Copy link
Owner

@Mboga can you try with this on line 499 instead of what you proposed:

data['nodes']['NestedFlowchart']['parameters']['filepath'] = '{}/flowcharts/reconstruct{}_.json'.format(output, i)

@Yarroudh Yarroudh pinned this issue Apr 14, 2023
@Mboga
Copy link
Author

Mboga commented Apr 17, 2023

Thanks @Yarroudh, this solves the error in the log.txt but only lod0 reconstruction takes place when I use the exact workflow. I will recheck to ensure that all is correct in the new reconstruct.json and reconstruct_.json files

@Mboga
Copy link
Author

Mboga commented Apr 17, 2023

@Yarroudh, re-checked to ensure all paths are correct- and subsequently achieved successful lod22 reconstruction :)

@Yarroudh
Copy link
Owner

Great. Thanks for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants