Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test('__ipairs is supported') are unassertive on travis's Lua 5.3 environment #38

Open
cpeosphoros opened this issue Aug 5, 2017 · 2 comments

Comments

@cpeosphoros
Copy link

They pass on 5.2.

I've noticed this on my fork, but it happens with pure 30log, too. I couldn't find the reason for that, though.

@airstruck
Copy link

The __pairs and __ipairs tests iterate tables with next and expect a particular sequence of values. The problem is next doesn't iterate in a predictable order, like pairs. If those tests pass reliably in any version of Lua, it's only by accident.

@cpeosphoros
Copy link
Author

Indeed.

While working in https://github.com/cpeosphoros/30log-plus I've got a couple of situations where code fails in production but passes the tests (not specifically this pairs/ipairs test harness).

I'm working on rewriting/complementing some of the tests and will PR here the ones relative to situations where behavior is not purposely changed in 30log-plus.

Repository owner deleted a comment from chasedson Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants