Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last update broke login in certain cases #217

Open
lapineige opened this issue Sep 11, 2024 · 14 comments · Fixed by #219
Open

Last update broke login in certain cases #217

lapineige opened this issue Sep 11, 2024 · 14 comments · Fixed by #219

Comments

@lapineige
Copy link
Member

lapineige commented Sep 11, 2024

https://forum.yunohost.org/t/cannot-log-in-with-latest-wallabag-update/31073

#216 broke login, yet I don't see the change that would cause this...
edit: maybe it was https://github.com/YunoHost-Apps/wallabag2_ynh/pull/215/files ?

Was it manually tested by anyone ? How did it go ?

@xplosionmind
Copy link

Damn, I realized it only now, but I am having the same trouble… I don’t even get the reset password email 😬

@gwen-lg
Copy link

gwen-lg commented Sep 14, 2024

I also have the trouble. With restore pre-upgrade backup, it's fix the problem.

And I have looked up to history, and see than the Automatic patch attempt for helpers 2.1 have delete the sources/patches files. For exemple a file name : main-00-ldap-auth.patch
I supposed this was not intended 🤔
see : c5515d9

@JimboJoe
Copy link
Contributor

Hi, your analysis is right: I had a Firefox wallabagger authentication problem, and after applying sources/patches/main-02-oauth-workaround.patch patch, it works again.

@JimboJoe
Copy link
Contributor

PR #218 to put them back ongoing

@cheywood
Copy link

Running 2.5.4~ynh7 I'm still seeing login issues; if I'm logged in with SSO I can't access Wallabag and a Firefox configuration (which was previously working) remains broken 🤷

@xplosionmind
Copy link

I Can’t even login via SSO in 2.5.4~ynh7

@lapineige lapineige reopened this Sep 17, 2024
@lapineige
Copy link
Member Author

@abochmann
Copy link

Also still affected here in Wallabag 2.5.4~ynh7

My (slightly redacted) Wallabag prod.log has:

[2024-09-20 08:59:56] request.INFO: Matched route "fos_user_security_check". {"route":"fos_user_security_check","route_parameters":{"_controller":"FOS\\UserBundle\\Controller\\SecurityController::checkAction","_route":"fos_user_security_check"},"request_uri":"https://yuno.XXX.de/wallabag/login_check","method":"POST"} []
[2024-09-20 08:59:56] app.ERROR: Authentication failure for user "YY", from IP "1.2.3.4", with UA: "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36". [] []
[2024-09-20 08:59:56] security.INFO: Authentication request failed. {"exception":"[object] (Symfony\\Component\\Security\\Core\\Exception\\BadCredentialsException(code: 0): Bad credentials. at /var/www/wallabag2/vendor/symfony/symfony/src/Symfony/Component/Security/Core/Authentication/Provider/UserAuthenticationProvider.php:89, Symfony\\Component\\Security\\Core\\Exception\\BadCredentialsException(code: 0): The presented password cannot be empty. at /var/www/wallabag2/vendor/symfony/symfony/src/Symfony/Component/Security/Core/Authentication/Provider/DaoAuthenticationProvider.php:61)"} []
[2024-09-20 08:59:56] security.DEBUG: Authentication failure, redirect triggered. {"failure_path":"/login"} []

@JimboJoe
Copy link
Contributor

Hm, the patches don't get applied by the ynh_setup_source helper... There's something I'm missing (probably simple)... @ericgaspar ?

@GannonTdW
Copy link

GannonTdW commented Sep 30, 2024

Hello,
As @abochmann, I am affected.
I upgrade from 2.5.4~ynh4 to 2.5.4~ynh7.
Restore backup is ok for me.

@retiolus
Copy link

I had the same error, trying to restore previous version didn't work...

https://paste.yunohost.org/raw/amutupexep

@michel-thomas
Copy link

I have the same problem with YNH 11.3.0.2 and wallabag 2.5.4~ynh8

@michel-thomas
Copy link

Still the same problem with YNH 11.3.0.2 and wallabag 2.5.4~ynh9 😞

@michel-thomas
Copy link

michel-thomas commented Nov 16, 2024

I use Ekpu tips to login again in my 2.5.4~ynh9 instance.

cd /var/www/wallabag2
bin/console --env=prod fos:user:change-password
Please give the username:myusername
Please enter the new password:
Changed password for user myusername

I set the same password that I used before the problem, and login is back!
Remaining problem is: I did it for only one user…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants