Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention built-in commands in the Cmd module #22

Open
Zaid-Ajaj opened this issue Sep 18, 2019 · 2 comments
Open

Mention built-in commands in the Cmd module #22

Zaid-Ajaj opened this issue Sep 18, 2019 · 2 comments

Comments

@Zaid-Ajaj
Copy link
Owner

The third chapter 3 hand-waves its way around built-in commands and instead defines its own commands Cmd.fromAsync that is used in the rest of the chapter. The chapter should give a note on why we are building our own commands instead of using built-in ones

  • To better understand commands (not just a black box)
  • Because built-in commands have "weird" conventions and namings that don't make sense for me
@MangelMaxime
Copy link
Collaborator

I didn't read the book yet so I don't know the context either which position you choose to stand on in it.

But, if the book is about learning Elmish etc. I think using the build-in functions/helpers is better. And then, have dedicated sections about making it fits the user needs, vision, etc.

@Zaid-Ajaj
Copy link
Owner Author

In the book I had chosen to explain what commands are, then build commands we need from scratch (i.e. From Async<'t> to Cmd<'t> explaining why we are doing it this way. I don't think built-in commands provide much value over those that you could implement yourself easily, except for a couple of them:

  • Cmd.none
  • Cmd.batch
  • Cmd.map

@Zaid-Ajaj Zaid-Ajaj reopened this Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants