New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REP-146 changes #54

Open

moriarty opened this issue Sep 12, 2019 · 1 comment

Labels

Contributor

moriarty commented Sep 12, 2019

We merged a PR #22 however it looks like things changed from robot/name and robot/type to robot_name and robot_type

ros-infrastructure/rep#104 (comment)

@moriarty fetchrobotics/fetch_robots#22 uses robot/name and robot/type but this REP uses robot_name and robot_type. Can we update fetchrobotics/fetch_robots#22 ? or change this REP?
c.f. https://github.com/ros-infrastructure/rep/pull/104/files/7410b7a91de3f2460a9065cf93a31cd45330f9fc#r187465995

The text was updated successfully, but these errors were encountered:

moriarty added the enhancement label

Contributor Author

moriarty commented Nov 21, 2019 •

edited

Loading

FYI @erelson & @cjds this is a simple task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment