Skip to content

Commit c373d72

Browse files
authored
Merge pull request #128 from bwrsandman/fix-trimmed-duplicate-review
Fix regression to cull_comments
2 parents 8903a2f + cd2e068 commit c373d72

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

post/clang_tidy_review/clang_tidy_review/__init__.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -1129,8 +1129,10 @@ def post_review(
11291129

11301130
set_output("total_comments", str(total_comments))
11311131

1132+
decorated_review = decorate_comments(review)
1133+
11321134
print("Removing already posted or extra comments", flush=True)
1133-
trimmed_review = cull_comments(pull_request, review, max_comments)
1135+
trimmed_review = cull_comments(pull_request, decorated_review, max_comments)
11341136

11351137
if not trimmed_review["comments"]:
11361138
print("Everything already posted!")
@@ -1140,10 +1142,8 @@ def post_review(
11401142
pprint.pprint(review, width=130)
11411143
return total_comments
11421144

1143-
decorated_review = decorate_comments(trimmed_review)
1144-
1145-
print("Posting the review:\n", pprint.pformat(decorated_review), flush=True)
1146-
pull_request.post_review(decorated_review)
1145+
print("Posting the review:\n", pprint.pformat(trimmed_review), flush=True)
1146+
pull_request.post_review(trimmed_review)
11471147

11481148
return total_comments
11491149

0 commit comments

Comments
 (0)