Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Upgrade to d3 6.0 #21

Open
HarelM opened this issue Jun 30, 2021 · 4 comments · May be fixed by #22
Open

Upgrade to d3 6.0 #21

HarelM opened this issue Jun 30, 2021 · 4 comments · May be fixed by #22

Comments

@HarelM
Copy link

HarelM commented Jun 30, 2021

I've seen the following issue, which might indicate there are issues solved in d3 6.0, I'm not sure, I don't fully understand what's not working for me with d3-zoom...
See here (last comment):
d3/d3-zoom#32

It might be worth updating the dependency.
Also it might be a good idea to change the version of this library to follow either the supported angular version or the supported d3 version.
But it might also be a bad idea :-)
@ZeevKatz
Copy link
Owner

ZeevKatz commented Jul 1, 2021 •
edited
Loading

Great suggestion, I'll take a look into [email protected] and probably bump its version as part of the next release.
Regarding your second, not sure it's a good idea but I'm not denying it...
Thanks for your interest in this library! 🙏

@HarelM
Copy link
Author

HarelM commented Jul 1, 2021

Sure :-) keep up the good work!

@HarelM
Copy link
Author

HarelM commented Aug 27, 2021

Any updates on this?

@ZeevKatz
Copy link
Owner

@HarelM Will be handled next week, or maybe you can help and open a PR? 🤭

@HarelM HarelM linked a pull request Oct 9, 2021 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade d3 to version 7.1.1 HarelM/ngx-d3
2 participants
@HarelM @ZeevKatz