Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menus in admin are not created when upgrading from 1.3.9 with SO installed. #7

Open
cooler0918 opened this issue May 22, 2019 · 7 comments
Assignees
Milestone

Comments

@cooler0918
Copy link

Hi I need to move finally move from 1.3.9 to at least 1.5.5f.

I installed SO on my migrated DB from 1.3.9 and found that while it works, I no longer have access to the configuration of SO. It was just not there. After studying the init file for a while I found that the auto install is looking for the configuration_group_ip of "Super Orders" and it seems that if it there it skips something. I tried deleting the id and it did created the menu entry but it only shows the version and wether the upgrade was completed. I would really appreciate any help you could provide.

@Zen4All
Copy link
Owner

Zen4All commented May 22, 2019

Hi, thanks for reporting. I'll check your problem, and see if an easy fix can be provided.
Also see forum post: https://www.zen-cart.com/showthread.php?200406-Super-Orders-v4-0-Support-Thread-(for-ZC-v1-5-x)&p=1357812#post1357812

@Zen4All Zen4All self-assigned this May 22, 2019
@Zen4All Zen4All added this to the v5.0.0 milestone May 22, 2019
@Zen4All
Copy link
Owner

Zen4All commented May 23, 2019

@cooler0918 As it looks like you were upgrading to SO 4, I need more info about the you had before.

@cooler0918
Copy link
Author

This is exactly the same issue from your source fork, with a bit more in depth information.

I had 3.0 installed on the 1.3.9h cart

@Zen4All
Copy link
Owner

Zen4All commented May 23, 2019

Ok, i never used SO3, so I will see if I have some time during the weekend to setup a test environment.

@cooler0918
Copy link
Author

stupid me didn't include link
DivaVocals#17

@Zen4All
Copy link
Owner

Zen4All commented May 23, 2019

Thanks

@Zen4All Zen4All added bug and removed Possible bug labels May 24, 2019
@Zen4All
Copy link
Owner

Zen4All commented May 24, 2019

I found the error.
As the installer was only looking for an existing version number it would continue for a clean install, as the number does not exist prior to this version.
Then it would find existing configuration values, and thus skipping them.
I made an extra check, and now it does update correctly (at least on my test environment).

Zen4All added a commit that referenced this issue May 24, 2019
This should fix the bug reported in #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants