Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip External Dependencies in zBuildThreadWaitForDependencies #40

Open
iNewLegend opened this issue May 23, 2024 · 0 comments
Open

Skip External Dependencies in zBuildThreadWaitForDependencies #40

iNewLegend opened this issue May 23, 2024 · 0 comments
Labels
todo has to be done

Comments

@iNewLegend
Copy link
Member

Title: Skip External Dependencies in zBuildThreadWaitForDependencies

Description:
In the zBuildThreadWaitForDependencies function within packages/zenflux-cli/src/core/build.ts, there is a TODO comment indicating that the function should favor skipping external dependencies. This needs to be implemented to improve the build process.

File: packages/zenflux-cli/src/core/build.ts

Line: 231 (approximate, based on the provided diff)

Current TODO Comment:

// TODO: It should favor skipping external dependencies.

Tasks:

  • Analyze the current handling of dependencies in the zBuildThreadWaitForDependencies function.
  • Implement logic to skip external dependencies.
  • Add appropriate tests to ensure the new logic works as expected.
  • Update documentation if necessary.

Additional Context:
The function currently processes dependencies from options.otherConfigs and checks them against packagesDependencies. The new logic should identify external dependencies and skip them during this process.

Feel free to adjust the issue description as needed.

Originally posted by @codiumai-pr-agent-pro[bot] in #35 (comment)

@iNewLegend iNewLegend added the todo has to be done label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo has to be done
Projects
None yet
Development

No branches or pull requests

1 participant